Bug 74862

Summary: [patch] update tuning(7) man page
Product: Documentation Reporter: Joel Dahl <joel>
Component: Books & ArticlesAssignee: Giorgos Keramidas <keramida>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
tuning.diff
none
tuning2.diff none

Description Joel Dahl 2004-12-08 18:40:24 UTC
(1) Remove reference to IDE_DELAY.  I'm not sure
    that my memory is correct, but I think that
    it was removed a long time ago, so I don't
    see any point in keeping it here.

(2) Reword things a bit since SCSI_DELAY defaults
    to 5000 milliseconds in CURRENT, not 15000.
Comment 1 Giorgos Keramidas freebsd_committer freebsd_triage 2004-12-09 01:54:43 UTC
On 2004-12-08 19:39, Joel Dahl <joel@automatvapen.se> wrote:
> (1) Remove reference to IDE_DELAY.  I'm not sure that my memory is
>     correct, but I think that it was removed a long time ago, so I
>     don't see any point in keeping it here.

IDE_DELAY is still used by the wd(4) driver of PC98.  Conditional
inclusion of text in manpages is not possible AFAIK, so we could
probably reword that part a bit to make it more obvious that it only
applies to PC98.

> (2) Reword things a bit since SCSI_DELAY defaults to 5000 milliseconds
>     in CURRENT, not 15000.

This part looks good.
Comment 2 Joel Dahl 2004-12-09 15:36:34 UTC
On Thu, 2004-12-09 at 03:54 +0200, Giorgos Keramidas wrote:
> On 2004-12-08 19:39, Joel Dahl <joel@automatvapen.se> wrote:
> > (1) Remove reference to IDE_DELAY.  I'm not sure that my memory is
> >     correct, but I think that it was removed a long time ago, so I
> >     don't see any point in keeping it here.
> 
> IDE_DELAY is still used by the wd(4) driver of PC98.  Conditional
> inclusion of text in manpages is not possible AFAIK, so we could
> probably reword that part a bit to make it more obvious that it only
> applies to PC98.

New patch attached. Any better?

(I had to check src/sys/pc98/pc98/wd.c for a reference to IDE_DELAY. If
this is an option available for the kernel configuration, why doesn't
NOTES for PC98 mention it?)

> 
> > (2) Reword things a bit since SCSI_DELAY defaults to 5000 milliseconds
> >     in CURRENT, not 15000.
> 
> This part looks good.
> 

Thanks. :-)
Comment 3 Giorgos Keramidas freebsd_committer freebsd_triage 2004-12-09 15:53:49 UTC
State Changed
From-To: open->patched

I committed a slightly modified version of your last patch 
(one that minimizes the lines affected by the change).
Comment 4 Giorgos Keramidas freebsd_committer freebsd_triage 2004-12-23 00:33:08 UTC
State Changed
From-To: patched->closed

I've now merged this to RELENG_5.  Thanks! 


Comment 5 Giorgos Keramidas freebsd_committer freebsd_triage 2004-12-23 00:33:08 UTC
Responsible Changed
From-To: freebsd-doc->keramida