Bug 75985

Summary:	Current DVD::Rip (0.50.18_1) incompatible with current transcode (0.6.12) in Cluster-mode
Product:	Ports & Packages	Reporter:	Stephan van Maris <svmaris>
Component:	Individual Port(s)	Assignee:	Michael Nottebrock <lofi>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Stephan van Maris 2005-01-09 10:40:24 UTC

When DVD::Rip is multiplexing the video- and the audio-stream with the
avimerge program (which is included in multimedia/transcode), it sends
the commandline arguments in an order that 0.6.12 does not understand.
Transcode 0.6.14 (on my Gentoo box) has no problems with it.

Fix: 

Until 0.6.14 will be available in ports, you can change the order
of the arguments in 

/usr/local/lib/perl5/site_perl/5.8.5/Video/DVDRip/Cluster/Title.pm

on the machine running dvdrip-master on line 314 so that the
'-i xxxxx' will be at the end of the avimerge command.

Comment 1 Michael Nottebrock 2005-01-09 14:23:49 UTC

Can you please submit a patch?

Comment 2 Michael Nottebrock freebsd_committer

2005-01-09 14:25:35 UTC

Responsible Changed
From-To: freebsd-ports-bugs->lofi

Over to maintainer (myself).

Comment 3 Stephan van Maris 2005-01-10 08:38:16 UTC

Sure:

(ps. I noticed that this affects non-cluster operations too and is not
limited to the machine running dvdrip-master)

patch-lib::Video::DVDRip::Title.pm

--- Video-DVDRip-0.50.18/lib/Video/DVDRip/Cluster/Title.pm      Sat Apr 10 11:18:03 2004
+++ Video-DVDRip-0.50.18-patched/lib/Video/DVDRip/Cluster/Title.pm      Sun Jan  9 17:41:11 2005
@@ -276,10 +276,10 @@
       } else {
               $command .=
                       "dr_exec avimerge".
-                       " -i $avi_file".
                       " -p $audio_file".
                       " -a $target_nr".
-                       " -o $avi_file.merged &&".
+                       " -o $avi_file.merged ".
+                       " -i $avi_file &&".
                       " mv $avi_file.merged $target_file &&".
                       " rm $audio_file &&".
                       " echo DVDRIP_SUCCESS";
@@ -312,10 +312,9 @@

       my $command =
               "mkdir -m 0775 -p '$audio_video_psu_dir' && ".
-               "${nice}dr_exec avimerge -i $avi_chunks_dir/*".
-               " -o $audio_video_psu_file ";
-       
+               "${nice}dr_exec avimerge -o $audio_video_psu_file";
       $command .= " -p $audio_psu_file " if not $self->is_ogg;
+        $command .= " -i $avi_chunks_dir/*";

       $command .= " && rm $avi_chunks_dir/*"
                       if $self->with_cleanup;



patch-lib::Video::DVDRip::Title.pm

--- Video-DVDRip-0.50.18/lib/Video/DVDRip/Title.pm      Sun Apr 18 16:19:58 2004
+++ Video-DVDRip-0.50.18-patched/lib/Video/DVDRip/Title.pm      Sun Jan  9 17:34:16 2005
@@ -2152,10 +2152,10 @@

               $command .=
                       "dr_exec avimerge".
-                       " -i $avi_file".
                       " -p $audio_file".
                       " -a $target_nr".
-                       " -o $avi_file.merged &&".
+                       " -o $avi_file.merged".
+                       " -i $avi_file &&".
                       " mv $avi_file.merged $avi_file &&".
                       " rm $audio_file &&".
                       " echo DVDRIP_SUCCESS";




Michael Nottebrock wrote:
> Can you please submit a patch?
>

Comment 4 Michael Nottebrock 2005-01-10 17:26:48 UTC

Can you resend the patches as proper attachments (either to GNATS or directly 
to me)? The patches you sent have tabs converted to spaces and don't apply.

Comment 5 Stephan van Maris 2005-01-11 02:31:45 UTC

I sent the patches directly to you.

On another note (since I've been actively using the Cluster-mode to
backup my DVD-collection): The 'Smart Deinterlacer' will crash randomly
on different nodes. So far I have had best results with the 'Zoom to Full
Frame'-option. I'll look into this problem later, but so far it seems like
a buggy transcode.

Michael Nottebrock wrote:
> Can you resend the patches as proper attachments (either to GNATS or directly 
> to me)? The patches you sent have tabs converted to spaces and don't apply.
>

Comment 6 Stephan van Maris 2005-01-11 02:41:37 UTC

I just remembered that I did something else to get DVD::Rip to
work: When you press 'Grab Frame' on the 'Clip & Zoom'-tab, DVD::Rip
calls 'identify' (part of the ImageMagick-tools), to get info on the
frame. But it passes the '-ping' option which apparently has been removed
a while ago, so it returns an error and doesn't work.

I worked around it by making a shell-wrapper for the 'real' identify-command
which only passes $2 (without the '-ping') to the binary, but I will
supply patches for DVD::Rip shortly.

Comment 7 Michael Nottebrock freebsd_committer

2005-01-11 22:41:07 UTC

State Changed
From-To: open->closed

Committed, thanks! (Imagemagick-issue fixed as well)