Bug 76036

Summary: respect bsd.java.mk 2.0 in java/jakarta-commons-pool,java/jakarta-struts,java/jmf
Product: Ports & Packages Reporter: toha <toha>
Component: Individual Port(s)Assignee: Herve Quiroz <hq>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description toha 2005-01-10 10:00:53 UTC
	Respect bsd.java.mk 2.0 in java/jakarta-commons-pool,java/jakarta-struts,java/jmf.
Comment 1 Herve Quiroz freebsd_committer 2005-01-10 16:03:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->hq

I'll handle this. 

Thanks for helping me upgrading Java ports. 

BTW, after a quick look at jakarta-commons-pool, there seem to be more 
improvements we could apply: 

- Use USE_ANT 
- Remove unneeded PLIST_SUB+= T=... 
- Remove pkg-plist using PLIST_FILES and %%JAVAJARDIR%% 
- Use JAVALIBDIR rather than JAVAJARDIR in BUILD_DEPENDS 
- Install documentation and JAR files using either cpio or INSTALL_DATA (which 
I prefer) rather than just CP. 
- Use ECHO_MSG rather than just ECHO 
- Use MASTER_SITE_APACHE_JAKARTA 

I'll have another look at all that and additional submit patches for you to 
review.
Comment 2 Herve Quiroz freebsd_committer 2005-01-18 09:37:34 UTC
State Changed
From-To: open->closed

Patches commited with some modifications. 

Pending improvements are: 

- java/jmf needs a second category. I was thinking of 'multimedia'. 

- java/jakarta-struts installs in ${JAVASHAREDIR}/${PKGNAME} where it could 
simply install in DATADIR=${JAVASHAREDIR}/${PORTNAME} as encouraged in the 
Porter's handbook. 

Thanks for your help on updating ports to bsd.java.mk 2.0.