Bug 76780

Summary:	[patch] re NIC driver update for D-Link DGE-528T detection
Product:	Base System	Reporter:	Andrus Nomm <andrus>
Component:	kern	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	5.3-RELEASE
Hardware:	Any
OS:	Any

Description Andrus Nomm 2005-01-28 03:10:18 UTC

      FreeBSD 5.3 failes to detect this GIGABIT network card. Card itself have common Realtek 8169S chipset but combination of vendor and device id does not mach.

Fix: 

I have created small patch what add entry for this card. I have tested on my PC for around weeks (card is inserted into fileserver). 

1. Patch is located at http://andrus.members.ee/re.patch
2. Copy it to /usr/src/
3. Patch it: (E.g: patch -p1 < re.patch )
4. Recompile kernel (dont forget to add "device re") into kernel config
5. reboot ;)
How-To-Repeat:       Just insert this card to PC. On box of card:
Vendor: D-Link
Model No: DGE-528T

pciconf -l shows for this card:
class=0x020000 card=0x43001186 chip=0x43001186 rev=0x10 hdr=0x0

Comment 1 ranajas 2005-05-07 17:26:56 UTC

Is this bug going to be solved?

Comment 2 Sergey Matveychuk freebsd_committer

2005-08-04 12:42:31 UTC

Send your patch as follow-up.
You can found a committer only if he'll see the patch.

-- 
Sem.

Comment 3 Anatoli Klassen 2005-08-04 15:04:26 UTC

Hi

I have the same card (D-Link DGE-528T) on RELENG_5.
After applying the patch the card is recognized by re driver and works
without any problems with 1Gbit speed.

Here is the patch from Andrus Nomm:

diff -ru old/sys/dev/re/if_re.c new/sys/dev/re/if_re.c
--- old/sys/dev/re/if_re.c	Tue Oct 12 21:51:20 2004
+++ new/sys/dev/re/if_re.c	Thu Jan 27 10:49:49 2005
@@ -160,6 +160,8 @@
  * Various supported device vendors/types and their names.
  */
 static struct rl_type re_devs[] = {
+        { DLINK_VENDORID, DLINK_DEVICEID_528T, RL_HWREV_8169S,
+                "D-Link DGE-528(T) Gigabit Ethernet Adapter" },
 	{ RT_VENDORID, RT_DEVICEID_8139, RL_HWREV_8139CPLUS,
 		"RealTek 8139C+ 10/100BaseTX" },
 	{ RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8169,
diff -ru old/sys/pci/if_rlreg.h new/sys/pci/if_rlreg.h
--- old/sys/pci/if_rlreg.h	Tue Oct 12 21:51:20 2004
+++ new/sys/pci/if_rlreg.h	Fri Jan 28 03:49:06 2005
@@ -793,6 +793,10 @@
  * D-Link DFE-530TX+ device ID
  */
 #define DLINK_DEVICEID_530TXPLUS		0x1300
+/*
+ * D-Link DFE-5280T device ID
+ */
+#define DLINK_DEVICEID_528T			0x4300

 /*
  * D-Link DFE-690TXD device ID

Comment 4 Anton Berezin freebsd_committer

2005-08-05 09:18:21 UTC

State Changed
From-To: open->closed

Committed to HEAD with minor whitespace and placement changes, thanks 
for the patch!  This will be MFCed to RELENG_6 and RELENG_5 in some 
time.