Bug 77391

Summary: Apache 2.x Modules depending on wrong Apache port
Product: Ports & Packages Reporter: Scot Hetzel <swhetzel>
Component: Individual Port(s)Assignee: freebsd-apache (Nobody) <apache>
Status: Closed FIXED    
Severity: Affects Only Me CC: apache
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Scot Hetzel 2005-02-11 15:20:09 UTC
Ports that previously depended on www/apache2 now show as depending on
www/apache13.

This problem is occuring because of a recent change to www/apache2's
Makefile.modules.3rd file (revision 1.18).  This change made the
APACHE_PORT variable overrideable even when WITH_APACHE2 is defined.
Previously, it set the variable with APACHE_PORT=www/apache2.

The APACHE_PORT variable gets defined in <bsd.port.mk> to www/apache13
if it wasn't previously defined.

The affected ports include <bsd.port.pre.mk> before "Makefile.modules.3rd".

Fix: 

With the attached fix the www/mod_frontpage2-rtr port now shows:

mod_frontpage2-5.0.2.2635|/usr/ports/www/mod_frontpage2-rtr|/usr/local|Microsoft
mod_frontpage (by RTR) for Apache
2.0|/usr/ports/www/mod_frontpage2-rtr/pkg-descr|swhetzel@gmail.com|www||||/usr/ports/www/apache2|/usr/ports/www/apache2
/usr/ports/www/frontpage|http://www.rtr.com

The attached patch replaces <bsd.port.[pre,post].mk> with
<bsd.port.mk> for all of the ports except for www/mod_frontpage2-rtr.
Instead <bsd.port.pre.mk> is
moved after "Makefile.modules.3rd"

mod_access_identd/Makefile
mod_access_referer/Makefile 
mod_accesscookie/Makefile
mod_auth_any/Makefile
mod_auth_cookie_mysql/Makefile
mod_auth_cookie_mysql2/Makefile
mod_auth_external2/Makefile
mod_auth_imap/Makefile
mod_auth_imap2/Makefile
mod_auth_mysql/Makefile
mod_auth_useragent/Makefile
mod_cfg_ldap/Makefile
mod_chroot/Makefile
mod_dosevasive20/Makefile
mod_frontpage-rtr/Makefile - email change only
mod_frontpage2-rtr/Makefile - email change and moved <bsd.ports.pre.mk>
mod_log_config-st/Makefile
mod_log_mysql/Makefile
mod_log_sql2/Makefile
mod_macro/Makefile
mod_macro2/Makefile
mod_musicindex/Makefile
mod_rpaf/Makefile
mod_tidy/Makefile
mod_vdbh/Makefile
mod_vhs/Makefile

------=_Part_730_18475341.1108134772017
Content-Type: application/x-gzip-compressed; name="apache_mod_fix.gz"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="apache_mod_fix.gz"

H4sICBh2DEIAA3BhdGNoMS5kaWZmAM2be3OiShqH/8ZP0ZudOjVTBgINeKHWPSFKMm68rZgzM1Vb
ZRFFpUbFI+R2cvLdt7vxQjeNSYyXSVU0Iv025n349Xtpq9O++2iAid/vOr2eGwRdr+9Ow/5Z3fnp
Dryxmyl9/CfTLtsAGzPA2cifuGfT3n1wNvPnYXD28PBwlj776X1m7oZzz733pkMwR0+B50+BIhUy
fW8wAOIdEOfoFVhdriiKGz6NoBSAeTcEUJY1oOQMqBiaBkQZ/QjYaDab3ThaAZfuLR6tAzlvaIqB
/iCjM+fnQFQKpzmQRY86OD/PALPVvTTtTvfiplqrlIQflk2OXVmNVq1qdxZHMqLkTXvju74L/nUb
9CX8b5Fmc1ea/Px3BqzeO/n03Gq2O3al2n4h/zRn5vRGLlxdnISu+27sBpI675/wjfpBSKxmOW/i
49UEDHN34M7d+bFoYKdPxUFRKR4UNRUI1iT2acXtLYgoGFrR0NQVEcgugwRv/JoJND5nKHEmYO40
D7LoMbdkgvE/9mqlWbZLgvDVLF9XG1egVi1bDduSwscQlEfOdOjW/CFoW2alboFOs9LkXJA0Cifj
fdEEMgDDI3rTIHTGY4N8MrVwqoGsmkeP+JNJ7hS5IAOET89ls/MC0AzXV3XLts0r6yXtwt5NZM/3
f3rukXhkJk+lEVIwwjQWGXObtQkyICYGJzBUKQzV0wLCED9iZ8Wxi7jaFzpZFh1kaQD+0UenTt3+
50ZzeSFfCDr1a2wXwYMP4T8j1CBBDS6EFZ1Xbdgds1brVsyOiU//1r622+WXs0/PA2o0wXLgz1d8
bsbwTSDehaOuM306PITsxB+SQ9YYxq/ZCxf4FQ0IDVjgCmFyJMNegVkW81gC0SNHAp/cIAMi5yEB
JH4kYEWQNcy69XIWzHuv0zkA7qMXhMHnT8+1ZtmsXZg2GroYsmJ0FIazbs9Hw0ZfwN9/gyWG36qd
r12zZZa/WhCB+M1sdBYvSwLMgH+CijcPn8DI6f2MbieseljVae074nqNnRJpQnfyFPw5Pg6d3CtI
xVSjKNVSIOXa5ImlvqJVo2FNsZCgFlKKqRPF1BeKiaitNsq/lwQuX8Q0OalWvWBPGnu30QlAHJPn
3thDcSV69dfhVFc4/9zrr4US/PYbemG2vtsvQDSB6IHYHScF/pcNOk0UOU8t/sJ5uiTP7sLIAVJv
iKexvpv1Vs2K6TO5dXZ+B8Dj3wJwF7FCutHNNwFMvwngprtAy9HhKzoDK50Cl/fBexFfhxr8i9lr
6Pqu+OOcF4BshDu6GHxuMuzYXbThPobufOocC+nk9Kk45yiccyk4Jw0KKEZp+PcLlHVDRtFHfoVy
jkaZN5zBuEiHIFAmYi5zwl/zpvPVanSqKGlptm2wcDT4haJiLpVEhGUiwvIyCgEAMNHujmTVmziz
46BHzfxBEaVsvUs7mZEJ1iCkWcsT1nIJ1kZhlLyJ7qMzmY1dgOPRvtTzpwPRmc2Qz5bv7DGT37iu
wyIJbAurdT0eNJwtLi6IogdWEzcq4Q5JPJIK0lN/MKiljQlKDvzHmUZIYfXTDT2XFs2yQxM00om/
QmjEj/z605Z8bqIzuz8+Gcn75fg8Yu71xqRLoUvnCq92njQnKHKMUNXQ9VWZUyA2KURfybSKhq7G
EFWJYKpLwSw3G5fVq5u21TXbVwhKUXzwwpFIbJaQF9vWZfX7C/gf8v7yPWf2GJQW6cxBa6CagnHU
5FgdYA/L713gzp0hiqePA1Zy+lS46LpTWtkpaZC3Gq/DP6b2xBtOE6bLhhInTCni8I888itQbDUU
DJw/952WvLMOCiREFhgAbxqXskjjC9SivXsKe4Nhd9w/QgyYmHh78hKmBEWLFTwRMYqhQw5znIEJ
2mAxvuQWyJJbWOgZnWrgHGNpkSyssQ5Pudn6gfs/yxyESFz8EqQAITVx4q2gw7Z8SHSoFvaZcPRG
c98/vNIx024f3jGG2NBOycfL6uvQLjEswZhWoGvquC6Dn+DRm807qbEkq5Pvit8+Xmnp+4F77wTe
vQvlg+PHnTw9hqNDuCSEXHOCimK4u3EkeLJsqEi31g1GZYUifzALJLP3AWpE9DRO1rtoZy9VK3SR
V2YH7lXrRLi0fQrXYO5PwxkKTMR5ePgdE/zZtyeIb08oriGAOMgyYI5DUMpgBiG04KrxKI20CfOL
RBXlAWbHumq2qxZCCH1K7KG6WW100K/VRrmqG/7ljoPzB4TTLfKhNHXDTDZ+RvAQnXM+nDjeGC22
E2yW6u0pKjrE8yE8rhPhrr0IP+RGuMGPRUPOM/1elfR71YUnW9dXuKtk31yivA33DdCy9IeFpbuC
FqbLag07+NPzZbvZ6LSWm0U+7ulys163Gmjhq3u9uR/4g5D+TODz7RNod9pfAI6rTaIpaGG5bHVX
15cB7ZtGt2K1rEbFZjoe5Ezb6rSsdv3FYCVqNcuyiVIgPZRl9TnG4O+kwfx2KZTKN20yjSS9tipv
Y3J14WujAxynTib+dFmdQes6iDfM4zfQ2B92cVTrDcXg8EEcf/bty8Z8e5xkVVc4peO00YmFVI1H
dhASWOBpkcBio4yhU29W8C1UEtYmMwAdvKlZ0fHEdIdsLHM3fH08HsOf5zjltOTM6Qos0xIs8yF6
dfNCDCBkMk7Q5loaokfX6F0LObJrQY/tWsi+ZdcCe1JKS/dX3bCK/1VHafonJt5+z3LClADhOnlE
K62aj5coChQnG9v6OkRj6Wgd5Y04XFdUAsqNbXXrP+z/1hYFsXUR1mr8kcUx/IVdOhFrLCIgeSii
5uQtW7ao7VeViyrZk7VpH1f/1sO/0ugLWyfOrgrF6P1SfHAGoItfruLoNAEbkKklu++Ezq0TuAG+
fvT2Kiv4QCcjG6UZ6FOuIh5QKgEcceKP27zpdG27tsjLFwkJmpFUlcl2R01ldpftLFOZOCgiOviN
Qs+6fSGPtsPTUl4Vjx2VuD+WCvxqwZjZtR3fN7XXinGKXxP57isNXrpWvHEr7Z4bZsQlhxdsZtrt
K32MIQHqsS0sKKVCmZHGqfSxw1gUVSabKhKpjp5+GRh3UPE7Jnl3gdfz8OvD05ec+iPBJceckFvz
pECcnaOBnOCSNzTJIpWbMJ1azr5ttH5G5IhoCnE9hRj5FK2CdrXZQL60by66i9x/9nMoTtwgwOny
/oqCdfN6GczgPvGyXQzKrdZlzbxC0Q3KYxZ/v5yAWmVxNBngnESLNBFSLb4Dlve9F3zcKn9tduv2
1Qs4SQ2L3kHvfOYMDs4tNen2mkmZ4a3dPMVkBiUY1Yq0XuaIXC4zINhFkBLWojwZWxOhJEu96F2m
PiU6s3cVZA6Z5IRe//BfO6EmTfW8TnleT3qeMsPz/Ho7ib7yPDOI/volDtri9WPyJTtcZntL7ost
b0h9UdIbnfFrgnDfvx0dHARq0u3jd8rMZhDW4TsziJEAzZCLdBEkT4ogyV7UsgV/tA56jjSi9H02
ou5HweHZiM25vUbErQjFWN+8YKBIRitwFIIakuQCyunfxU3n4rBIRF+lye0cif8DmPMkIdw/AAA=

------=_Part_730_18475341.1108134772017--
How-To-Repeat: 
Go to one of the Apache 2.* Module ports, and perform a "make
describe" or "make clean". For example:

cd /usr/ports/www/mod_frontpage2-rtr
make describe

mod_frontpage2-5.0.2.2635|/usr/ports/www/mod_frontpage2-rtr|/usr/local|Microsoft
mod_frontpage (by RTR) for Apache
2.0|/usr/ports/www/mod_frontpage2-rtr/pkg-descr|swhetzel@gmail.com|www||||/usr/ports/www/apache13|/usr/ports/www/apache13
/usr/ports/www/frontpage|http://www.rtr.com
Comment 1 Scot Hetzel 2005-02-11 18:59:03 UTC
I didn't notice ${PORTDIRS} when I removed <bsd.port.pre.mk>.  After
applying the patch in this PR, you'll need to change:

    ${PORTSDIR}/www/

to

   ${.CURDIR}/../

In all the affected ports except for mod_frontpage2-rtr, as it is
using ${.CURDIR}/../.

clement has reverted his change to "Makefiles.modules.3rd" back to
revision 1.17 in www/apache2.  If we make these changes now, then when
he puts it back in, it won't break theses ports again :).

Scot
Comment 2 jeh freebsd_committer 2005-02-11 19:48:13 UTC
mod_auth_mysql has been patched
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2005-02-11 21:31:38 UTC
Responsible Changed
From-To: freebsd-ports-bugs->apache

Probably the most logical place to track this.
Comment 4 Clement Laforet freebsd_committer 2005-06-06 15:36:28 UTC
State Changed
From-To: open->closed

it has been fixed. future bsd.apache.mk is on the way and add better  
dependency tracking.