Bug 77817

Jesus R. Camou wrote:
>>Number:         77817
>>Category:       docs
>>Synopsis:       [PATCH] vinum chapter (handbook) fixes
>>Confidential:   no
>>Severity:       non-critical
>>Priority:       medium
>>Responsible:    freebsd-doc
>>State:          open
>>Quarter:        
>>Keywords:       
>>Date-Required:
>>Class:          change-request
>>Submitter-Id:   current-users
>>Arrival-Date:   Mon Feb 21 01:10:11 GMT 2005
>>Closed-Date:
>>Last-Modified:
>>Originator:     Jesus R. Camou
>>Release:        FreeBSD 4.11-STABLE i386
>>Organization:
>>Environment:
> 
> System: FreeBSD opensea.mephis.org 4.11-STABLE FreeBSD 4.11-STABLE #0: Sun Feb 13 21:22:53 MST 2005 jcamou@opensea.mephis.org:/usr/obj/usr/src/sys/HACKED i386
> 
> 
>>Description:
> 
> 
> 	o Isn't Hiten Pandya's email hmp@FreeBSD.org? Change this.
> 	o s/4.x/4.X/ and s/5.x/5.X/
> 	o add white space: devicename -> device name
> 
> 
>>How-To-Repeat:
> 
> 
>>Fix:
> 
> 
> --- vinum.diff begins here ---
> Index: chapter.sgml
> ===================================================================
> RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/handbook/vinum/chapter.sgml,v
> retrieving revision 1.34
> diff -u -r1.34 chapter.sgml
> --- chapter.sgml	11 Jan 2005 12:34:29 -0000	1.34
> +++ chapter.sgml	21 Feb 2005 00:42:10 -0000
> @@ -2,7 +2,7 @@
>  	The Vinum Volume Manager
>  	By Greg Lehey (grog at lemis dot com)
>  
> -	Added to the Handbook by Hiten Pandya <hiten@FreeBSD.org>
> +	Added to the Handbook by Hiten Pandya <hmp@FreeBSD.org>
>  	and Tom Rhodes <trhodes@FreeBSD.org>
>  
>  	For the FreeBSD Documentation Project
> @@ -1078,8 +1078,8 @@
>  	    start</command> command.</para>
>  
>  	  <note><para>The following paragraphs are outlining the steps
> -	    needed for FreeBSD 5.x and above.  The setup required for
> -	    FreeBSD 4.x differs, and is described below in <xref
> +	    needed for FreeBSD 5.X and above.  The setup required for
> +	    FreeBSD 4.X differs, and is described below in <xref
>  	    linkend="vinum-root-4x">.</para></note>
>  
>  	  <para>By placing the line:</para>
> @@ -1096,7 +1096,7 @@
>  	    root device in <filename>/etc/fstab</filename>, and passes
>  	    this information on to the kernel.	When it comes to mount
>  	    the root filesystem, the kernel figures out from the
> -	    devicename provided which driver to ask to translate this
> +	    device name provided which driver to ask to translate this
>  	    into the internal device ID (major/minor number).</para>
>  	</listitem>
>        </itemizedlist>
> --- vinum.diff ends here ---
> 
> 
> 
>>Release-Note:
>>Audit-Trail:
>>Unformatted:
> 

You are correct about the hmp address. However the .x to .X in the
version numbering already had been done yesterday.

Could you please send a updated patch without the uppercase X diff?

Thanks!

-- 
Kind regards,

      Remko Lodder  ** remko@elvandar.org
      Reporter DSINET  **  remko@DSINet.org
      Founder Tienervaders  ** remko@tienervaders.org
      FreeBSD Documentation Project  ** remko@FreeBSD.org

On Mon, Feb 21, 2005 at 06:21:31AM +0100, Remko Lodder wrote:
> Jesus R. Camou wrote:
> >>Number:         77817
> >>Category:       docs
> >>Synopsis:       [PATCH] vinum chapter (handbook) fixes
> >>Confidential:   no
> >>Severity:       non-critical
> >>Priority:       medium
> >>Responsible:    freebsd-doc
> >>State:          open
> >>Quarter:        
> >>Keywords:       
> >>Date-Required:
> >>Class:          change-request
> >>Submitter-Id:   current-users
> >>Arrival-Date:   Mon Feb 21 01:10:11 GMT 2005
> >>Closed-Date:
> >>Last-Modified:
> >>Originator:     Jesus R. Camou
> >>Release:        FreeBSD 4.11-STABLE i386
> >>Organization:
> >>Environment:
> >
> >System: FreeBSD opensea.mephis.org 4.11-STABLE FreeBSD 4.11-STABLE #0: Sun 
> >Feb 13 21:22:53 MST 2005 
> >jcamou@opensea.mephis.org:/usr/obj/usr/src/sys/HACKED i386
> >
> >
> >>Description:
> >
> >
> >	o Isn't Hiten Pandya's email hmp@FreeBSD.org? Change this.
> >	o s/4.x/4.X/ and s/5.x/5.X/
> >	o add white space: devicename -> device name
> >
> >
> >>How-To-Repeat:
> >
> >
> >>Fix:
> >
> >
> >--- vinum.diff begins here ---
> >Index: chapter.sgml
> >===================================================================
> >RCS file: 
> >/home/ncvs/doc/en_US.ISO8859-1/books/handbook/vinum/chapter.sgml,v
> >retrieving revision 1.34
> >diff -u -r1.34 chapter.sgml
> >--- chapter.sgml	11 Jan 2005 12:34:29 -0000	1.34
> >+++ chapter.sgml	21 Feb 2005 00:42:10 -0000
> >@@ -2,7 +2,7 @@
> > 	The Vinum Volume Manager
> > 	By Greg Lehey (grog at lemis dot com)
> > 
> >-	Added to the Handbook by Hiten Pandya <hiten@FreeBSD.org>
> >+	Added to the Handbook by Hiten Pandya <hmp@FreeBSD.org>
> > 	and Tom Rhodes <trhodes@FreeBSD.org>
> > 
> > 	For the FreeBSD Documentation Project
> >@@ -1078,8 +1078,8 @@
> > 	    start</command> command.</para>
> > 
> > 	  <note><para>The following paragraphs are outlining the steps
> >-	    needed for FreeBSD 5.x and above.  The setup required for
> >-	    FreeBSD 4.x differs, and is described below in <xref
> >+	    needed for FreeBSD 5.X and above.  The setup required for
> >+	    FreeBSD 4.X differs, and is described below in <xref
> > 	    linkend="vinum-root-4x">.</para></note>
> > 
> > 	  <para>By placing the line:</para>
> >@@ -1096,7 +1096,7 @@
> > 	    root device in <filename>/etc/fstab</filename>, and passes
> > 	    this information on to the kernel.	When it comes to mount
> > 	    the root filesystem, the kernel figures out from the
> >-	    devicename provided which driver to ask to translate this
> >+	    device name provided which driver to ask to translate this
> > 	    into the internal device ID (major/minor number).</para>
> > 	</listitem>
> >       </itemizedlist>
> >--- vinum.diff ends here ---
> >
> >
> >
> >>Release-Note:
> >>Audit-Trail:
> >>Unformatted:
> >
> 
> You are correct about the hmp address. However the .x to .X in the
> version numbering already had been done yesterday.

You're completely right about that, I don't know why I missed it.

Here's an updated patch, thanks!

-- 
Jesus R. Camou <jcamou@COX.net>
jcamou@es.FreeBSD.org

Comment 3 Remko Lodder 2005-02-21 20:20:29 UTC

Responsible Changed
From-To: freebsd-doc->remko

Grab this PR. Passing it through my mentor before i can commit it.

Comment 4 Remko Lodder 2005-02-21 20:48:51 UTC

State Changed
From-To: open->closed

Patch committed, thanks!