Bug 77851

Summary: articles/committers-guide: change Approved -> Reviewed
Product: Documentation Reporter: Florent Thoumie <flz>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
article.sgml.diff none

Description Florent Thoumie 2005-02-21 12:00:38 UTC 
These are two different statements of the Committer's Guide. I think the
second one is erroneous.

"Approved by" is only acceptable from non-mentored src committers -- mentored
committers can provide a "Reviewed by" but not an "Approved by".

Until your mentor decides (and announces with a forced commit to access) that
you have learned the ropes and are ready to commit on your own, you should not
commit anything without first getting your mentor's review and approval, and
you should document that approval with an Approved by: line in the commit
message.
Comment 1 Simon L. B. Nielsen freebsd_committer freebsd_triage 2005-02-21 12:19:23 UTC 
On 2005.02.21 12:59:15 +0100, Florent Thoumie wrote:

> These are two different statements of the Committer's Guide. I think the
> second one is erroneous.


It isn't, it's different topics.

> "Approved by" is only acceptable from non-mentored src committers -- mentored
> committers can provide a "Reviewed by" but not an "Approved by".


This is from the "2.1 Policy for doc/ committer activity in src/"
section, ie. only for doc committers (if they are mentored or not)
and only wrt. commtting to src/.

> Until your mentor decides (and announces with a forced commit to access) that
> you have learned the ropes and are ready to commit on your own, you should not
> commit anything without first getting your mentor's review and approval, and
> you should document that approval with an Approved by: line in the commit
> message.


This is general for all committers being mentored and is correct
(though not entirely at least wrt. to doc/ people but that's another
matter).

-- 
Simon L. Nielsen
Comment 2 Florent Thoumie 2005-02-21 12:24:59 UTC 
Simon L. Nielsen wrote:
> On 2005.02.21 12:59:15 +0100, Florent Thoumie wrote:
>
>
>>These are two different statements of the Committer's Guide. I think the
>>second one is erroneous.
>
>
> It isn't, it's different topics.
>
>
>>"Approved by" is only acceptable from non-mentored src committers -- mentored
>>committers can provide a "Reviewed by" but not an "Approved by".
>
>
> This is from the "2.1 Policy for doc/ committer activity in src/"
> section, ie. only for doc committers (if they are mentored or not)
> and only wrt. commtting to src/.
>
>
>>Until your mentor decides (and announces with a forced commit to access) that
>>you have learned the ropes and are ready to commit on your own, you should not
>>commit anything without first getting your mentor's review and approval, and
>>you should document that approval with an Approved by: line in the commit
>>message.
>
>
> This is general for all committers being mentored and is correct
> (though not entirely at least wrt. to doc/ people but that's another
> matter).

	Ok this was a bit unclear, though i read these parts 2 or 3
	times.

	Thanks.
Comment 3 Florent Thoumie 2005-02-22 12:19:50 UTC 
	You can close this PR, I thought you already did it.
Comment 4 Giorgos Keramidas freebsd_committer freebsd_triage 2005-02-22 12:58:33 UTC 
State Changed
From-To: open->closed

Closed at submitter's request.