Bug 78116

Summary: USE_JAVA misplet in /usr/ports/devel/argouml/Makefile 1.4
Product: Ports & Packages Reporter: Michel Lavondes <fox>
Component: Individual Port(s)Assignee: Herve Quiroz <hq>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
argouml.diff none

Description Michel Lavondes 2005-02-26 15:00:32 UTC
In /usr/ports/devel/argouml/Makefile, USE_JAVA is misplet "USE_JAVE". If I read the code right, this means that the dependency on a suitable JDK won't be recorded, and that an install with no JDK will fail.

Fix: 

Use the correct spelling.
How-To-Repeat: I suspect trying to install argouml without any JDK installed will do it.
Comment 1 Herve Quiroz freebsd_committer freebsd_triage 2005-02-26 15:50:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->hq

I'll handle this
Comment 2 Herve Quiroz freebsd_committer freebsd_triage 2005-02-27 00:11:36 UTC
Dear maintainer,

Here is a patch which contains a fix for the issue reported as well as a
few other improvements to devel/argouml:

- Fix mispelled USE_JAVA knob [1]
- Remove unndeed PORTREVISION=0 statement
- Register run dependency on javavmwrapper
- Improve launcher shell script (use javavmwrapper 2.0)
- Use SUB_FILES to configure launcher shell script
- Remove trailing space in pkg-plist to calm portlint
- Add $FreeBSD$ tags

Could you please review it?

Herve
Comment 3 Herve Quiroz freebsd_committer freebsd_triage 2005-02-27 00:11:50 UTC
State Changed
From-To: open->feedback

Maintainer asked for feedback
Comment 4 Herve Quiroz freebsd_committer freebsd_triage 2005-03-13 02:18:49 UTC
State Changed
From-To: feedback->closed

Patch commited after maintainer approval timeout. 

Thanks for your contribution!