Bug 78239

Summary: [patch] Building www from cvs without doc
Product: Documentation Reporter: Devon H. O'Dell <dodell>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Devon H. O'Dell 2005-03-01 12:40:11 UTC 
	I might be missing something here, but it appears to me to be
	impossible to build the www tree without also having the doc/
	module.

Fix: The following patch corrects the issue for me.
How-To-Repeat: 	From a checkout of www sources, simply:

	> make
	"/usr/home/dodell/www/en/../share/mk/web.site.mk", line
	134: /usr/home/dodell/www/en/../../doc/share/mk/doc.common.mk not found.
	Define $WITHOUT_DOC for building without the doc/ module.

	Ok, so I run:

	> make -DWITHOUT_DOC
	:
	: builds a bit
	:
	cd: can't cd to /usr/home/dodell/www/en/doc/../../../doc/en_US.ISO8859-1

	It would appear to me that since I told it I wanted to build without
	the doc/ module, it should not try to at any point during the build
Comment 1 Simon L. B. Nielsen freebsd_committer freebsd_triage 2005-03-01 12:51:15 UTC 
On 2005.03.01 13:34:00 +0100, Devon H. O'Dell wrote:
> 
> 	I might be missing something here, but it appears to me to be
> 	impossible to build the www tree without also having the doc/
> 	module.


This is correct - it's a choice, not a bug.  The web site you will get
built withoing having doc/ is incomplete, though you can do www/ build
without doc/ to do tests of most individual pages.

This should probably be documented more clearly...

-- 
Simon L. Nielsen
Comment 2 Devon H. O'Dell 2005-03-01 12:54:57 UTC 
On Tue, 2005-03-01 at 13:51 +0100, Simon L. Nielsen wrote:
> On 2005.03.01 13:34:00 +0100, Devon H. O'Dell wrote:
> > 
> > 	I might be missing something here, but it appears to me to be
> > 	impossible to build the www tree without also having the doc/
> > 	module.
> 
> This is correct - it's a choice, not a bug.  The web site you will get
> built withoing having doc/ is incomplete, though you can do www/ build
> without doc/ to do tests of most individual pages.
> 
> This should probably be documented more clearly...
> 

Then perhaps it would be beneficial to apply the second part of the
patch only? It seems logical that this is only an issue for people new
to the www build process (such as myself, heh), so just typing ``make''
and having it tell me about the WEB_ONLY knob as well would probably
save some confusion in the future.

Sorry if this is well-documented on the list; I guess I should have
searched here first.

--Devon
Comment 3 Simon L. B. Nielsen freebsd_committer freebsd_triage 2005-03-01 13:07:27 UTC 
On 2005.03.01 13:54:57 +0100, Devon H. O'Dell wrote:
> On Tue, 2005-03-01 at 13:51 +0100, Simon L. Nielsen wrote:
> > On 2005.03.01 13:34:00 +0100, Devon H. O'Dell wrote:
> > > 
> > > 	I might be missing something here, but it appears to me to be
> > > 	impossible to build the www tree without also having the doc/
> > > 	module.
> > 
> > This is correct - it's a choice, not a bug.  The web site you will get
> > built withoing having doc/ is incomplete, though you can do www/ build
> > without doc/ to do tests of most individual pages.
> > 
> > This should probably be documented more clearly...
> 
> Then perhaps it would be beneficial to apply the second part of the
> patch only? It seems logical that this is only an issue for people new
> to the www build process (such as myself, heh), so just typing ``make''
> and having it tell me about the WEB_ONLY knob as well would probably
> save some confusion in the future.


Yes, I will try to have a look at it when I get home tonight.

> Sorry if this is well-documented on the list; I guess I should have
> searched here first.


Well, I actually don't think it is... The dependency was added when
the mirror list was started to be auto generated from XML, I don't
think it has been brought up later.

In general not that many people build www/ by them self :-).

-- 
Simon L. Nielsen
Comment 4 Simon L. B. Nielsen freebsd_committer freebsd_triage 2005-03-01 23:09:14 UTC 
State Changed
From-To: open->closed

I committed an improved the error message based on the patch in the 
PR.  Thanks for the submission!