Bug 78990

Summary: [update] {news,chinese}/tin: integrate patch
Product: Ports & Packages Reporter: Yen-Ming Lee <leeym>
Component: Individual Port(s)Assignee: Andrey A. Chernov <ache>
Status: Closed FIXED    
Severity: Affects Only Me CC: ache
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
tin.diff none

Description Yen-Ming Lee 2005-03-18 18:10:00 UTC 
- update chinese/tin to catch up with news/tin
- add knobs in news/tin to make it easier for chinese/tin to customize settings
- respect WITHOUT_NLS
Comment 1 Yen-Ming Lee freebsd_committer freebsd_triage 2005-03-18 19:36:39 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ache

Over to the maintainer.
Comment 2 Andrey A. Chernov freebsd_committer freebsd_triage 2005-03-19 15:00:35 UTC 
Responsible Changed
From-To: ache->freebsd-ports-bugs

1) This is two ports with two different maintainers, please break it into  
two PR's 
2) Anything else than --with-mime-default-charset=US-ASCII will break 
other national charsets. 
3) Visible tunung variables must have WITH_TIN_ prefix to allow set them all 
at once without conflicts in the /etc/make.conf
Comment 3 yssu 2005-03-25 06:14:19 UTC 
Acknowledged!! :D

BTW... Would anybody like to maintain this ports?
Since I'm in charge some important projects, there's not much time to care
about this ports..


-- 
Sincerely Yours,
Yen-Shuo Su.
Mobile: +886-937-348222
Campus Computer Communication Association
National Chiao Tung University, Taiwan
Comment 4 Yen-Ming Lee freebsd_committer freebsd_triage 2005-03-25 10:27:07 UTC 
On Fri, Mar 25, 2005 at 02:14:19PM +0800, Yen-Shuo Su wrote:
> Acknowledged!! :D
> 
> BTW... Would anybody like to maintain this ports?
> Since I'm in charge some important projects, there's not much time to care
> about this ports..

Okay, I'll takeover chinese/tin.

For the issues that ache@ mentioined:

1. please check the news/tin part of this patch, and I'll take care of
   chinese/tin part of it.

2. --with-mime-default-charset will set the default value of MM_CHARSET,
   it is safe to change its value at compile-time or run-time (by setenv).

   Unlike --disable-mime-strict-charset, set --with-mime-default-charset
   to charset other than US-ASCII will NOT break other national charsets.

   Even add MM_CHARSET variable in news/tin, it's still set to US-ASCII
   by default, but use "?=" to allow users or slave ports to overwrite it.

   chinese/tin need to change the default value of MM_CHARSET to Big5,
   otherwise it can't display asciiart correctly. chinese/tin can't work
   with ncurses either. That's why I need to add optional variables with
   default values for "charset" and "screen".

3. It might be reasonable to put TIN_ prefixes to all variables, however,
   some of these variables are commonly used (EDITOR, MM_CHARSET), it will
   be convenient if we can utilize them.

   The other WITH/WITHOUT variables can be replaced by using OPTIONS.
   The config result will be saved in /var/db/ports and only apply to the
   port which save it. I myself prefer this alternative way.

   But if you insist, add TIN_ prefixes to these variables (TIN_EDITOR,
   TIN_SCREEN, TIN_MM_CHARSET, WITHOUT_TIN_PGP_GPG ...) are okay too.

-- 
Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2005-04-06 23:54:39 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ache

Over to maintainer of news/tin.
Comment 6 Andrey A. Chernov freebsd_committer freebsd_triage 2005-10-03 12:33:07 UTC 
State Changed
From-To: open->feedback

Several changes and PRs/patches requested from submitter during discussion, 
feedback needed.
Comment 7 Yen-Ming Lee freebsd_committer freebsd_triage 2006-10-16 02:43:30 UTC 
State Changed
From-To: feedback->closed

Outdated PR