|Summary:||[i386] [patch] Small optimization for i386/support.s|
|Product:||Base System||Reporter:||Andrey Simonenko <simon>|
|Component:||i386||Assignee:||freebsd-i386 (Nobody) <i386>|
|Severity:||Affects Only Me|
Description Andrey Simonenko 2005-03-21 15:40:02 UTC
suword(), suword16(), subyte() and copyinstr() from i386/support.s restore "trashed" register %ecx, but this register is not really trashed in case of non I386_CPU in su*() functions and in copyinstr(). The same situation with the same functions in amd64/support.S. And the same situation with 4.x, 5.x and HEAD.
Comment 1 Remko Lodder 2010-07-14 08:06:16 UTC
State Changed From-To: open->feedback Hello, the code in question is using 'rcx' now instead of 'ecx'to restore the registers. That might have solved your problem can you please have a look at that please and confirm whether it's still relevant?
Comment 2 b. f. 2011-05-31 19:44:42 UTC
Feedback for this PR was received on the freebsd-i386 mailing list, but was not recorded here: http://lists.freebsd.org/pipermail/freebsd-i386/2010-July/008712.html b.
Comment 3 Brendan Fabeny 2011-06-22 14:59:43 UTC
State Changed From-To: feedback->open Feedback has been received
Comment 4 Eitan Adler 2017-12-31 08:00:54 UTC
For bugs matching the following criteria: Status: In Progress Changed: (is less than) 2014-06-01 Reset to default assignee and clear in-progress tags. Mail being skipped