Bug 79707
| Summary: | [NONMAINTAINER UPDATE] www/resin: [allow port to build again] | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Boris Kovalenko <boris> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Herve Quiroz <hq> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | jb.quenot | ||||||||||
| Priority: | Normal | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Hello! Sorry, patch is of course for www/resin3. Subject is just typo. With respect, Boris Responsible Changed From-To: freebsd-ports-bugs->hq I'll handle this. State Changed From-To: open->feedback Maintainer asked for feedback. * Herve Quiroz: > Do you approve the patch in this PR? No I don't. Please see revision 1.6 at cvsweb, someone intentionally broke the port by removing the WRKDIR assignment: http://www.freebsd.org/cgi/cvsweb.cgi/ports/www/resin2/Makefile Because WRKDIR is defined in bsd.port.post.mk, it must be set earlier in the Makefile if we want to use it. -- Jean-Baptiste Quenot http://caraldi.com/jbq/ ---------------------------------------------------------------- Jean-Baptiste Quenot wrote:
Hello!
Hmm... really... Will You approve this patch? I've checked, it
compiles now.
> * Herve Quiroz:
>
>> Do you approve the patch in this PR?
>
>
> No I don't. Please see revision 1.6 at cvsweb, someone intentionally
> broke the
> port by removing the WRKDIR assignment:
>
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/www/resin2/Makefile
>
> Because WRKDIR is defined in bsd.port.post.mk, it must be set earlier
> in the
> Makefile if we want to use it.
Hi Jean-Baptiste, On Mon, Apr 11, 2005 at 06:10:28AM +0200, Jean-Baptiste Quenot wrote: > >Do you approve the patch in this PR? > > No I don't. Please see revision 1.6 at cvsweb, someone intentionally > broke the > port by removing the WRKDIR assignment: > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/www/resin2/Makefile > > Because WRKDIR is defined in bsd.port.post.mk, it must be set earlier in the > Makefile if we want to use it. WRKDIR value is computed because of the .for loop. These loop statements are indeed evaluated first in a Makefile and the computation of the value cannot be postponed. Here is a patch to solve this: I removed the first .for loop by passing all filenames in the same command-line, and the second .for loop by switching to a sh for/do/done loop. I also converted some ECHO_CMD to ECHO_MSG. BTW, the port still does not clean correctly when built/installed as a user: $ cd /tmp/ $ cvs -q -d :pserver:anoncvs@anoncvs.at.freebsd.org:/home/ncvs co resin2 $ make install deinstall clean [...] ===> Cleaning for resin-2.1.16 rm: /tmp/resin2/work/resin-2.1.16/libexec/libresin.so: Permission denied But that's another issue. We should first unbreak the port. So please review the attached patch. Herve * Herve Quiroz: > Here is a patch to solve this: I removed the > first .for loop by passing all filenames in the same command-line, and > the second .for loop by switching to a sh for/do/done loop. Thank you very much for that patch. The WRKSRC declaration can now be safely omitted, so please find attached the definitive patch based on yours and an update of the resinctl script. For the problem of installation by user, it seems that libexec/libresin.so is created by resin Makefile's install target, thus owned by root. Best regards, -- Jean-Baptiste Quenot http://caraldi.com/jbq/ ---------------------------------------------------------------- State Changed From-To: feedback->closed Patch commited. Thanks for your contribution! |
[DESCRIBE CHANGES] Wonder why .for is cutting ${WRKSRC} from path but it does. So logic is slightly changed to allow port to build again. BROKEN is removed. Question to maintainer - may be better to change portnames to resin2 and resin3 respectively? Port maintainer (jb.quenot@caraldi.com) is cc'd. Generated with FreeBSD Port Tools 0.63