Bug 80915
| Summary: | MySQL port building requires -O on 4.x releases and 4-STABLE | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Clifton Royston <cliftonr> |
| Component: | Individual Port(s) | Assignee: | Alex Dupre <ale> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Clifton Royston
2005-05-11 21:50:00 UTC
Responsible Changed From-To: freebsd-ports-bugs->ale Over to maintainer to decide In my opinion, if someone changes default CFLAGS, he knows what he's doing and should be ready to bear consequences. I don't think port should hold user's hand Plus included patch will kill any user provided optimizations, like -O2 or -O3. pav:
I believe your comments indicate that you misunderstood the PR
(ports/80915); in fact you read it backwards, so to speak.
The port is *broken* with the *default* CFLAGS value (which is empty).
The port *only* works if you *change* CFLAGS to a *non-default* setting
which includes -O. That is not the official default setting.
The problem is masked for many advanced FreeBSD users, who will have
edited their /etc/make.conf at some point to turn on -O -pipe and then
forgotten about it. I suspect that's why it wasn't discovered before
now.
That is why my instructions for reproducing the bug begin by telling
you to get rid of all customizations in /etc/make.conf. Please try
actually reproducing this on a clean install of 4.x and you will see
what I mean.
I agree with you it's perfectly acceptable for a port to break if
you've done custom tweaks to your make settings. It's not acceptable
for a port to *require* custom tweaks to your make settings, especially
if it doesn't tell you about it.
(The failure symptoms in this case are particularly mystifying too. It
required several weeks of off-and-on tinkering and quite a leap of
imagination to get from what appears to be a link problem with
libraries to a compiler optimization setting.)
-- Clifton
--
Clifton Royston -- cliftonr@tikitechnologies.com
Tiki Technologies Lead Programmer/Software Architect
"I'm gonna tell my son to grow up pretty as the grass is green
And whip-smart as the English Channel's wide..."
-- 'Whip-Smart', Liz Phair
State Changed From-To: open->closed CFLAGS is set by default to -O -pipe. Setting it to null (empty string) in make.conf is not a default behaviour. |
