Summary: | [patch] boot0cfg emits bogus error | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Peter Schuller <peter.schuller> | ||||
Component: | bin | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||
Status: | Open --- | ||||||
Severity: | Affects Only Me | Keywords: | patch | ||||
Priority: | Normal | ||||||
Version: | 5.3-RELEASE | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Peter Schuller
2005-05-14 21:00:22 UTC
Responsible Changed From-To: freebsd-bugs->brucec Take. Author: brucec Date: Wed Jun 23 14:28:08 2010 New Revision: 209469 URL: http://svn.freebsd.org/changeset/base/209469 Log: If a device can't be opened, don't keep going but display the error returned from open() and quit. PR: bin/81035 Submitted by: Peter Schuller <peter.schuller at infidyne.com> Approved by: rrs (mentor) Modified: head/usr.sbin/boot0cfg/boot0cfg.c Modified: head/usr.sbin/boot0cfg/boot0cfg.c ============================================================================== --- head/usr.sbin/boot0cfg/boot0cfg.c Wed Jun 23 14:19:19 2010 (r209468) +++ head/usr.sbin/boot0cfg/boot0cfg.c Wed Jun 23 14:28:08 2010 (r209469) @@ -356,6 +356,8 @@ write_mbr(const char *fname, int flags, if (n != mbr_size) errx(1, "%s: short write", fname); return; + } else { + err(1, "write_mbr: %s", fname); } /* _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" State Changed From-To: open->patched Fixed in HEAD. Author: brucec Date: Sat Aug 7 12:58:01 2010 New Revision: 211013 URL: http://svn.freebsd.org/changeset/base/211013 Log: MFC r209469: If a device can't be opened, don't keep going but display the error returned from open() and quit. PR: bin/81035 Submitted by: Peter Schuller <peter.schuller at infidyne.com> Approved by: rrs (mentor) Modified: stable/8/usr.sbin/boot0cfg/boot0cfg.c Directory Properties: stable/8/usr.sbin/boot0cfg/ (props changed) Modified: stable/8/usr.sbin/boot0cfg/boot0cfg.c ============================================================================== --- stable/8/usr.sbin/boot0cfg/boot0cfg.c Sat Aug 7 12:54:12 2010 (r211012) +++ stable/8/usr.sbin/boot0cfg/boot0cfg.c Sat Aug 7 12:58:01 2010 (r211013) @@ -356,6 +356,8 @@ write_mbr(const char *fname, int flags, if (n != mbr_size) errx(1, "%s: short write", fname); return; + } else { + err(1, "write_mbr: %s", fname); } /* _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" Author: brucec Date: Sat Aug 7 13:02:26 2010 New Revision: 211014 URL: http://svn.freebsd.org/changeset/base/211014 Log: MFC r209469: If a device can't be opened, don't keep going but display the error returned from open() and quit. PR: bin/81035 Submitted by: Peter Schuller <peter.schuller at infidyne.com> Approved by: rrs (mentor) Modified: stable/7/usr.sbin/boot0cfg/boot0cfg.c Directory Properties: stable/7/usr.sbin/boot0cfg/ (props changed) Modified: stable/7/usr.sbin/boot0cfg/boot0cfg.c ============================================================================== --- stable/7/usr.sbin/boot0cfg/boot0cfg.c Sat Aug 7 12:58:01 2010 (r211013) +++ stable/7/usr.sbin/boot0cfg/boot0cfg.c Sat Aug 7 13:02:26 2010 (r211014) @@ -355,6 +355,8 @@ write_mbr(const char *fname, int flags, if (n != mbr_size) errx(1, "%s: short write", fname); return; + } else { + err(1, "write_mbr: %s", fname); } if (flags != 0) _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" State Changed From-To: patched->closed Fix has been merged to stable/7 and stable/8. State Changed From-To: closed->open The patch was backed out: upon failure write_mbr now deliberately keeps going. Responsible Changed From-To: brucec->freebsd-bugs Back to the pool. For bugs matching the following criteria: Status: In Progress Changed: (is less than) 2014-06-01 Reset to default assignee and clear in-progress tags. Mail being skipped Keyword: patch or patch-ready – in lieu of summary line prefix: [patch] * bulk change for the keyword * summary lines may be edited manually (not in bulk). Keyword descriptions and search interface: <https://bugs.freebsd.org/bugzilla/describekeywords.cgi> |