Bug 81271

Summary: devel/apache-ant with option NOPORTDOCS has incorrect package list
Product: Ports & Packages Reporter: Björn König <bkoenig>
Component: Individual Port(s)Assignee: Herve Quiroz <hq>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-Makefile-always-with-manpages
none
patch-pkg-plist none

Description Björn König 2005-05-19 17:50:02 UTC

The package list is incorrect while using NOPORTDOCS.

Fix: I attached three patches.

The file 'patch-Makefile-always-with-manpages' causes that manpages
will always be installed regardless to NOPORTDOCS. This is what I would
expect and recommend.

The second file 'patch-Makefile-without-manpages' is an alternative to
the first patch and follows the maintainer's intention to don't install
manpages if NOPORTDOCS is defined. Then you don't need to declare
manpages at all.

The third file 'patch-pkg-plist' fixes the package list as regards the
manual files which won't be installed if NOPORTDOCS is defined.

#### 1 ###########################################################

#### 2 ###########################################################

--- Makefile.orig	Thu May 19 15:55:21 2005
+++ Makefile	Thu May 19 15:56:24 2005
@@ -39,8 +39,10 @@
 MANPAGE_SUBDIR=	apache-ant-manpage
 MANPAGE_WRKSRC=	${WRKSRC}/${MANPAGE_SUBDIR}
 
+.if !defined(NOPORTDOCS)
 MAN1=		ant.1
 MAN5=		build.xml.5
+.endif
 
 do-patch:
 	@${CP} ${FILESDIR}/ant ${WRKSRC}/bin/ant
--- patch-Makefile-without-manpages ends here ---

#### 3 ###########################################################
How-To-Repeat: 

# cd /usr/ports/devel/apache-ant
# make -DNOPORTDOCS package
Comment 1 Herve Quiroz freebsd_committer freebsd_triage 2005-05-20 12:28:35 UTC
Responsible Changed
From-To: freebsd-ports-bugs->hq

I'll handle this.
Comment 2 Herve Quiroz freebsd_committer freebsd_triage 2005-05-25 17:32:33 UTC
State Changed
From-To: open->closed

Patch commited. 

Thanks for your contribution!