Summary: | [maintainer] qalculate 0.7.2 -> 0.8.0 + libqalculate port | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Sergey Akifyev <asa> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Sergey Akifyev
2005-06-03 11:40:01 UTC
> There are 2 reasons, that I've included shar instead of diff:
> 1) diff weights more
> 2) to avoid various patching problems
Why we require diffs?
We apply patches and make a commit. After applying patches we can easy
see what files added/removed. We need explicitly add and/or remove files
in repository.
What can I do with your shar? I should extract files and make a diff and
apply it to the exist port.
Moreover when we look at a patch we can easily understand what changed.
--
Sem.
On ×Ó, 2005-06-05 at 21:47 +0400, Sergey Matveychuk wrote: > > There are 2 reasons, that I've included shar instead of diff: > > 1) diff weights more > > 2) to avoid various patching problems > > Why we require diffs? > We apply patches and make a commit. After applying patches we can easy > see what files added/removed. We need explicitly add and/or remove files > in repository. > What can I do with your shar? I should extract files and make a diff and > apply it to the exist port. > > Moreover when we look at a patch we can easily understand what changed. AFAIK, you do not _require_ diffs, you prefer them. Logically this port was not a patch to previous version, it was built from scratch. Also, last commit broke qalculate patch stage (there are 2 pairs of same patches committed under different names, I don't know how this happened). So, my own CVS desyncronised with FreeBSD ports. This way I have more chances to make a mistake when diff'ing. -- regards, Sergey Akifyev <http://dpx.niibaca.ru> AGAVA Software Company <http://www.agava.com> PGP key available from: ftp://ftp.gascom.ru/pub/PGP-keys/asa.txt Sergey Akifyev wrote:
> AFAIK, you do not _require_ diffs, you prefer them. Logically this port
We _require_ diffs, but prefer unify diffs ;-)
--
Sem.
State Changed From-To: open->closed Committed, thanks! |