Bug 84243
| Summary: | Fix of pkg-plist for palm/prc-tools port | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Cochran <jdc> | ||||||||
| Component: | Individual Port(s) | Assignee: | Sergey Matveychuk <sem> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | ||||||||||
| Priority: | Normal | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
John Cochran
2005-07-28 18:40:17 UTC
===> Deinstalling prc-tools-2.3_2 pkg_delete: file '/usr/local/pilot/man/man1/cpp.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-ar.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-as.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-readelf.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-nm.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-objdump.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-ranlib.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-size.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-windres.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/build-prc.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-strip.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-dlltool.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-gdb.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/gcov.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-ld.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-nlmconv.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/palmdev-prep.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-addr2line.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-c++filt.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-ar.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-as.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-g++.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-gcc.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-nm.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-objcopy.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-objdump.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-ranlib.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-size.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-strings.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-strip.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-windres.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-ld.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-dlltool.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-nlmconv.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-readelf.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/cccp.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-g++.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-gcc.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-objcopy.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/m68k-palmos-strings.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-addr2line.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man1/arm-palmos-c++filt.1.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man7/gfdl.7.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man7/gpl.7.gz' doesn't exist pkg_delete: file '/usr/local/pilot/man/man7/fsf-funding.7.gz' doesn't exist pkg_delete: couldn't entirely delete package (perhaps the packing list is incorrectly specified?) -- Sem. State Changed From-To: open->feedback Wait for a submitter feedback. Hi there, I'm afraid that the submitted patch isn't correct. The real problem why this port is marked as broken is that it ends up installing a different set of files the second time you do a "make (re)install", which means that the packing list is not correct the second time around. It would appear that it's the binutils installation that mucks things up somehow. I didn't have the time to fully understand why some files aren't included in subsequent install runs, but I found a workaround that is unlikely to have any adverse side-effects. Basically, the offending files (bfd info documentation) are removed in the post-configure step. The previous maintainer already did this for the gdb build, so I only added it for the binutils. It's also worth noting that the files that were installed were a mixture of binutils' bfd's and multi-bfd's files. With the attached patch, only multi-bfd's files are installed, which makes more sense to start with (even if I've never had to refer to said documentation while developing Palm applications). I've verified the port with the patch applied thouroughly, and it installs, packages, deinstalls, reinstalls, pkg_adds and pkg_deletes cleanly without leaving any traces behind (on 5.4-REL with updated ports tree). Also, the pkg-plist file has now been restructured to be ordered, which should make it easier to maintain in the future. As the man pages are already listed in the Makefile (MAN? variables), and are therefore not needed to be listed in the pkg-plist. See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-autoplist.html for details. I hope the attached patch will bring back this port to non-deprecated status. Thanks, /Johny Responsible Changed From-To: freebsd-ports-bugs->sem I'll care Looks like the port installs some files before install stage: === Checking filesystem state list of files present before this port was installed but missing after it was deinstalled) ./usr/local/pilot missing ./usr/local/pilot/arm-palmos missing ./usr/local/pilot/arm-palmos/sys-include missing ./usr/local/pilot/arm-palmos/sys-include/COPIED missing ./usr/local/pilot/lib missing ./usr/local/pilot/lib/gcc-lib missing ./usr/local/pilot/lib/gcc-lib/m68k-palmos missing ./usr/local/pilot/lib/gcc-lib/m68k-palmos/2.95.3-kgpd missing ./usr/local/pilot/m68k-palmos missing ./usr/local/pilot/m68k-palmos/sys-include missing ./usr/local/pilot/m68k-palmos/sys-include/COPIED missing ================================================================ This makes pointyhat mad :) -- Sem. Sergey Matveychuk wrote: > Looks like the port installs some files before install stage: <snip> Argh. What a nuisance. I'll have a look at this as soon as I can, but my main FreeBSD workstation just had a system disk crash overnight, so I'll need to get it to PXE boot first. Please don't kill this port until I've had a chance to look at this once again! I should be able to check it and submit a new patch within a week I think (unless setting up a diskless environment takes far longer than expected) :) > This makes pointyhat mad :) Me puts the pointy hat on the port instead ;-) Cheers, /Johny -- Johny Mattsson - Making IT work ,-. ,-. ,-. When all else fails, http://www.earthmagic.org _.' `-' `-' Murphy's Law still works! Hello! Do you plan any progress on the PR? -- Sem. It's time to decide a fate of the port. -- Sem. Hello again, Sorry I've gone all quiet. With business trips, conferences, and a bad bout of the flu, this got pushed down on the priority list for a while. I'll be spending the evening trying to repair this port... If I don't get it done by tomorrow evening, then I can fully understand if you axe it (I'll be gone for another 2 weeks after that). Worse comes to worst, I can always submit the fixed port as a brand new one once I've got it all working I suppose. Best regards, /Johny -- Johny Mattsson - Making IT work ,-. ,-. ,-. When all else fails, http://www.earthmagic.org _.' `-' `-' Murphy's Law still works! Okay, I think I've managed to convince this silly port not to spew detritus all over the PREFIX during the build phase (whoever thought it was a good idea to install-sh things from the configure script?!). I'm just running a build (takes a long time on my slow system), and will be doing the install/deinstall/reinstall checks of the plist tomorrow morning or during the day. Expect an updated patch within 24h :) Oh, and is it possible for you to edit this PR so that I get cc'd on any updates to it? Pretty please? :) Thanks, /Johny Alright, attached is a new, re-tested diff. I've built it with a read-only PREFIX, and it seems to be behaving appropriately now. With this diff there are four added files: files/post-patch-binutils:configure files/post-patch-gcc2:configure.in files/post-patch-gcc3:configure.in files/post-patch-gdb:configure.in I've stepped the portrevision since I'm not installing as much as previously (removed some of the info files). If you disagree with the stepping of the portrevision, you may of course ignore it. Should pointyhat find any problems that I haven't caught in my testing, please cc me on this email address (or even better, get me added to the PR so it happens automagically). I'll endeavour to fix it quickly, but as mentioned, I'll be out of town for a week and a half now. Kind regards, /Johny -- Johny Mattsson - Making IT work ,-. ,-. ,-. When all else fails, http://www.earthmagic.org _.' `-' `-' Murphy's Law still works! State Changed From-To: feedback->closed Fix committed, thanks! |
