Bug 85243

Summary: Missing icmp related abbreviations for pf.conf(5) in icmp(4)
Product: Documentation Reporter: Thomas E. Zander <riggs>
Component: Books & ArticlesAssignee: Bruce M Simpson <bms>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
icmp.4.diff none

Description Thomas E. Zander 2005-08-23 11:20:23 UTC 
According to the manpage pf.conf(5), rules may contain icmp-types
and/or codes by a name, for example somethig like
pass out inet proto icmp all icmp-type echoreq

Further it says "Text names for ICMP types and codes are listed in
icmp(4) and icmp6(4)."

While this is true for icmp6(4), the manpage icmp(4) lacks the
information.

Fix: 

OpenBSD's icmp(4) manpage contains the textnames for icmp types
and codes which can be used by pf. Merging the tables containing
these abbreviations into FreeBSD's icmp(4) manpage should do well.
Comment 1 Daniel Gerzo 2006-01-02 00:28:29 UTC 
Hello,

   Here is diff with information obtained from OpenBSD.

   slightly discussed with mlaier@ :)
   
-- 
Sincerely,
   Daniel Gerzo
Comment 2 Bruce M Simpson freebsd_committer freebsd_triage 2007-02-09 02:23:32 UTC 
Responsible Changed
From-To: freebsd-doc->bms

I'll take it
Comment 3 Bruce M Simpson freebsd_committer freebsd_triage 2007-02-09 12:30:32 UTC 
State Changed
From-To: open->patched

committed, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-02-09 12:30:35 UTC 
bms         2007-02-09 12:30:17 UTC

  FreeBSD src repository

  Modified files:
    share/man/man4       icmp.4 
  Log:
  Add lists of ICMP types and codes for user and developer reference.
  Cross-reference pf.conf(5) which is able to use these definitions.
  
  PR:             85243
  Submitted by:   Daniel Gerzo
  Obtained from:  OpenBSD
  MFC after:      1 day
  
  Revision  Changes    Path
  1.20      +72 -2     src/share/man/man4/icmp.4
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-02-10 12:01:47 UTC 
bms         2007-02-10 12:01:39 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    share/man/man4       icmp.4 
  Log:
  MFC rev 1.20:
    Add lists of ICMP types and codes for user and developer reference.
    Cross-reference pf.conf(5) which is able to use these definitions.
  
  PR:             85243
  Submitted by:   Daniel Gerzo
  Obtained from:  OpenBSD
  
  Revision  Changes    Path
  1.16.2.1  +72 -2     src/share/man/man4/icmp.4
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Bruce M Simpson freebsd_committer freebsd_triage 2007-02-10 12:01:49 UTC 
State Changed
From-To: patched->closed

MFC