Summary: | [patch] ${CC} should be added to ${MAKE_ENV} when ${USE_GMAKE} is set | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jean-Yves Lefort <jylefort> | ||||
Component: | Individual Port(s) | Assignee: | Port Management Team <portmgr> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Jean-Yves Lefort
2005-09-14 09:40:10 UTC
On Wed, 14 Sep 2005 04:42:55 -0400 michael johnson <buhnux@gmail.com> wrote: > On Sep 14, 2005, at 4:39 AM, Jean-Yves Lefort wrote: > > > GNU make does not automatically inherit ${CC}; adding it to > > ${MAKE_ENV} in bsd.port.mk would be profitable. > > > > The same would be true about ${CXX} also then. Indeed: --- bsd.port.mk.orig Wed Sep 14 10:37:43 2005 +++ bsd.port.mk Wed Sep 14 10:47:42 2005 @@ -1460,6 +1460,7 @@ .if defined(USE_GMAKE) BUILD_DEPENDS+= gmake:${PORTSDIR}/devel/gmake CONFIGURE_ENV+= MAKE=${GMAKE} +MAKE_ENV+= CC="${CC}" CXX="${CXX}" .endif .if defined(USE_GCC) -- Jean-Yves Lefort jylefort@FreeBSD.org http://lefort.be.eu.org/ Responsible Changed From-To: freebsd-ports-bugs->portmgr bsd.port.mk patch. State Changed From-To: open->analyzed Added to exp build. Thanks. State Changed From-To: analyzed->suspended It needs more investigation. We still keep it in devel/portmk for further tests. State Changed From-To: suspended->open At the portmgr meeting at BSDCan 2007, we agreed that this is still a worthwhile idea. I'm working on it with another improvements and a big cleanup for the ports using MAKE_ENV, so please keep this open for the meantime, I'll send a patch soonish. I have a big patch for ports, but there are still some that should be cleaned up. -- Gabor Kovesdan FreeBSD Volunteer EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org State Changed From-To: open->suspended Awaiting patch from gabor. State Changed From-To: suspended->closed CC was added to MAKE_ENV for all ports pav 2008-07-24 22:29:33 UTC FreeBSD ports repository Modified files: Mk bsd.gcc.mk bsd.port.mk games/formido Makefile graphics/gdal/files patch-swig-python-GNUmakefile x11-toolkits/xmhtml Makefile x11-wm/sapphire Makefile Log: - Add CC and CXX to MAKE_ENV for all ports PR: ports/86106, ports/101120 (based on) Revision Changes Path 1.18 +1 -3 ports/Mk/bsd.gcc.mk 1.600 +4 -3 ports/Mk/bsd.port.mk 1.8 +2 -1 ports/games/formido/Makefile 1.2 +1 -1 ports/graphics/gdal/files/patch-swig-python-GNUmakefile 1.32 +1 -1 ports/x11-toolkits/xmhtml/Makefile 1.21 +1 -1 ports/x11-wm/sapphire/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" |