Bug 86437

Summary:	tcp_input.c and tcp_sack.c refer to obsolete ICPM_BANDLIM
Product:	Base System	Reporter:	Gary W. Swearingen <garys>
Component:	kern	Assignee:	Andre Oppermann <andre>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	5.4-RELEASE
Hardware:	Any
OS:	Any

Description Gary W. Swearingen freebsd_committer

2005-09-22 00:40:03 UTC

These files reference the obsolete variable ICMP_BANDLIM.  I don't
know if the includes are still needed or not, but if nobody wants to
find out, the comments should probably be changed to "for unknown
purpose" or something.

src/sys/netinet/tcp_input.c:#include <netinet/ip_icmp.h>   /* for ICMP_BANDLIM             */
src/sys/netinet/tcp_input.c:#include <netinet/icmp_var.h>  /* for ICMP_BANDLIM             */
src/sys/netinet/tcp_sack.c:#include <netinet/ip_icmp.h>    /* for ICMP_BANDLIM             */
src/sys/netinet/tcp_sack.c:#include <netinet/icmp_var.h>   /* for ICMP_BANDLIM             */

How-To-Repeat: n/a

Comment 1 Craig Rodrigues freebsd_committer

2005-09-22 01:17:39 UTC

Responsible Changed
From-To: freebsd-bugs->andre

Andre is cleaning up all the TCP code.

Comment 2 Andre Oppermann freebsd_committer

2006-02-18 17:05:18 UTC

State Changed
From-To: open->patched

Fixed in tcp_input.c rev. 1.289 and tcp_sack.c rev. 1.29.

Comment 3 Gavin Atkinson freebsd_committer

2009-11-08 15:52:20 UTC

State Changed
From-To: patched->closed

This is fixed in HEAD, 8.x and 7.x, and given it's only a minor 
change in comments doesn't really need to be merged to 6.x.  Close.