Bug 87273

Summary: Add check for quotes around COMMENT to devel/portlint
Product: Ports & Packages Reporter: Erwin Lansing <erwin>
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
portlint-quoted-comment.diff none

Description Erwin Lansing freebsd_committer freebsd_triage 2005-10-11 19:10:14 UTC 
	

I just noticed that a new port submitted had a quoted "COMMENT" which
portlint didn't complain about. This patch adds a warning for this.
Comment 1 Erwin Lansing freebsd_committer freebsd_triage 2005-10-11 19:11:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2005-10-16 19:30:43 UTC 
State Changed
From-To: open->feedback

What is the reasoning behind this?  Is that it looks bad in pkg_info?  The 
reason I ask is that some ports use quoting within COMMENT, but do not 
quote the whole COMMENT (e.g. games/gweled).  I think this is fine. 

If that is the case, then I think your pattern might be a bit too restrictive. 
We could opt for something like the following instead: 

if ($whole =~ /^COMMENT[+?]?=[ t]+"[^"+]"$/m) { 

Thoughts?
Comment 3 Erwin Lansing freebsd_committer freebsd_triage 2005-10-16 19:52:37 UTC 
Yes, you're right. I just copied the regex from one of the other checks
without giving it much thought. Only quoting the whole COMMENT should be
flagged, quotes inside the message are ok.
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2005-10-22 20:44:59 UTC 
State Changed
From-To: feedback->closed

Committed, and integrated into portlint 2.7.5.