Bug 87374
| Summary: | incorrect use of WITH_THEORA vs. WITH_LIBTHEORA in some ports | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Zahemszky@, Gábor <gabor> |
| Component: | Individual Port(s) | Assignee: | Michael Johnson <ahze> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed
From-To: freebsd-ports-bugs->ahze
Over to maintainer of vlc{,-devel} for further reasoning.
Ahze, can you afterwards assign it to nobutaka?
State Changed From-To: open->analyzed - Over to nobutaka Responsible Changed From-To: ahze->nobutaka Mark this analyzed Responsible Changed From-To: nobutaka->ahze Commit to libxine done. Hand this PR over to the maintainer of vlc and vlc-devel. State Changed From-To: analyzed->closed - close this pr since we now have a ports/KNOBS file. vlc and vlc-devel knob names will be updated on the next release. |
Many ports in the audio and multimedia categories (and maybe others) have optional dependencies to special libraries (eg. libogg, libvorbis). It looks like in the FreeBSD ports-tree, there isn't a correct way to tell the libtheora dependency. Eg, in multimedia, there are libxine, vlc and vlc-devel, which use the WITH_LIBTHEORA (or WITHOUT_LIBTHEORA) Makefile variable, but ffmpeg-devel, mplayer and transcode use the WITH_THEORA (ot WITHOUT_THEORA) variables. So if somebody'd like to include (exclude) libtheora, she has to define two variables in /etc/make.conf: WITH_THEORA and WITH_LIBTHEORA (or w/o). It would be better to use one; and after the other similar variable's name, I think WITH_THEORA is the correct name. Fix: In /usr/ports/multimedia/{libxine,vlc,vlc-devel}/Makefile, in the next (or similar lines), change the WITH(OUT)?_LIBTHEORA strings to WITH(OUT)?_THEORA. == if !defined(WITHOUT_LIBTHEORA) && (exists(${LOCALBASE}/lib/libtheora.so.1) || defined (WITH_LIBTHEORA)) == How-To-Repeat: egrep -R 'WITH(OUT)?_(LIB)?THEORA' /usr/ports