Bug 87498
| Summary: | Additional quoting checks for portlint | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bill Fenner <fenner> | ||||
| Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-ports-bugs->marcus Over to maintainer. State Changed From-To: open->closed Committed, and integrated into portlint 2.7.5. |
We've been having more and more problems caused by quoting, particularly because of DEPRECATED's obscure requirements. ports/87396 makes it so that bsd.port.mk won't have any more quoting problems, but I understand that bsd.port.mk patches are never "no-brainers" to commit, so until then, having a portlint that knows the rules will help. Fix: This patch requires quotes around all of BROKEN, FORBIDDEN, MANUAL_PACKAGE_BUILD, NO_CDROM, NO_PACKAGE, RESTRICTED. It also enforces the obscure rules about DEPRECATED: it needs either no quotes or two sets, so if it's set to ${BROKEN} it needs to be set to "${BROKEN}", (since BROKEN has one set). cvs diff: Diffing . cvs diff: Diffing src How-To-Repeat: Use BROKEN= "Doesn't work" and DEPRECATED=${BROKEN} and type make TRYBROKEN=YES check-sanity or FORBIDDEN= http://www.site.com/vulnerable;strangeurltoo