Bug 87891

Summary: upgrade port: net/poptop
Product: Ports & Packages Reporter: Oleg M. Golovanov <olmi>
Component: Individual Port(s)Assignee: Sergey Matveychuk <sem>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Oleg M. Golovanov 2005-10-24 02:00:27 UTC 
PoPToP is a PPTP daemon. It is compatible with the Microsoft Windows VPN adapter.
Comment 1 Sergey Matveychuk freebsd_committer freebsd_triage 2005-10-24 07:32:00 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sem

Take it.
Comment 2 Sergey Matveychuk freebsd_committer freebsd_triage 2005-10-24 07:57:48 UTC 
There are a few notes on the patch:
1) Do not touch 'Date created:' and 'Whom:'. They reflect a history: who 
created the port and when. You can change a history :-)
As well as $FreeBSD$ tag. Don't touch it or reset to $FreeBSD$ is you 
aren't sure.

2) PORTREVISION shoud be reseted to zero when PORTVERSION has updated. 
(but there are exeptions sometimes).

3) Do not use patch-aa, patch-ab file names for new patches. They are 
deprecated. (Do not rename old patches unless you really need, but do 
not create new ones with the old scheme). See 
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-patch.html
for details.

4) Do not hardcode /usr/local path. Use ${LOCALBASE} or ${PREFIX} 
instead. (A port is installed in ${PREFIX} and looks for libraries, 
includes etc. in ${LOCALBASE}).
You do it in patches to man pages. Usualy you should change it to 
%%PREFIX%% and then change it with REINPLACE_CMD in post-patch stage.

5) Do not insert extra spaces (CRs, TABs and SPACEs) in Makefile).
portlint -A will show you where they are. (Use portlint always but you 
can filter some its warnings. AI is always worse than yours).

6) As port maintainer think to change old-style rc-script to new rcNG 
sometime. We'll start a 'convert all rc-scripts in ports tree in rcNG' 
company after 6.0-RELEASE.
You can read a great Yar's article: http://people.freebsd.org/~yar/rcng/

If you have no objection on all above, I'll make changes and commit your 
patch.

-- 
Sem.
Comment 3 olmi 2005-10-24 08:35:19 UTC 
OK
Comment 4 Sergey Matveychuk freebsd_committer freebsd_triage 2005-10-24 10:22:18 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-10-27 17:41:19 UTC 
darrenr     2007-10-27 16:41:13 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_5)
    contrib/ipfilter     ipmon.c 
  Log:
  Only write the PID file out when becoming a daemon.
  
  PR:             bin/87891
  
  Revision  Changes    Path
  1.18.2.1  +2 -2      src/contrib/ipfilter/ipmon.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"