|Summary:||[maintainer-update] net-mgmt/nagios[-plugins] Hard coded references, packing list and install path updates|
|Product:||Ports & Packages||Reporter:||Jarrod Sayers <jarrod>|
|Component:||Individual Port(s)||Assignee:||Sergey Matveychuk <sem>|
|Severity:||Affects Only Me|
Description Jarrod Sayers 2005-11-01 09:30:15 UTC
Mostly just housekeeping. - Remove hard coded references to the www group and spool directory - Support changes made to user, group or spool directory to be recorded in the packing list correctly - Added support for overriding install path of web component with an aim to migrate the default from share/nagios to www/nagios - Added temporary knob to allow users to migrate to the new default without actually setting the path Fix: Patch is rather lengthly, it can be downloaded from: http://www.netleader.com.au/stuff/freebsd/ports-net-mgmt-nagios-wwwdir.diff Files altered: - ports/net-mgmt/nagios/Makefile - ports/net-mgmt/nagios/pkg-plist - ports/net-mgmt/nagios/files/MESSAGE.tmpl - ports/net-mgmt/nagios-plugins/Makefile - ports/net-mgmt/nagios-plugins/pkg-plist
Comment 1 Sergey Matveychuk 2005-11-01 09:54:03 UTC
Jarrod Sayers wrote: > -USE_AUTOMAKE_VER= 19 > -USE_AUTOCONF_VER= 259 > +USE_AUTOMAKE_VER=19 > +USE_AUTOCONF_VER=259 The common style is to place tab after '='. > +%%NAGIOSWWWDIR%%/locale/de/LC_MESSAGES/nagios-plugins.mo > +%%NAGIOSWWWDIR%%/locale/fr/LC_MESSAGES/nagios-plugins.mo > +@dirrm %%NAGIOSWWWDIR%%/locale/de/LC_MESSAGES > +@dirrm %%NAGIOSWWWDIR%%/locale/de > +@dirrm %%NAGIOSWWWDIR%%/locale/fr/LC_MESSAGES > +@dirrm %%NAGIOSWWWDIR%%/locale/fr > +@dirrm %%NAGIOSWWWDIR%%/locale What is a weird idea to place locale files in www dir? -- Sem.
Comment 2 Sergey Matveychuk 2005-11-01 09:54:56 UTC
Responsible Changed From-To: freebsd-ports-bugs->sem Take it.
Comment 3 Jarrod Sayers 2005-11-01 11:53:17 UTC
On Tue, 1 Nov 2005, Sergey Matveychuk wrote: > Jarrod Sayers wrote: >> -USE_AUTOMAKE_VER= 19 >> -USE_AUTOCONF_VER= 259 >> +USE_AUTOMAKE_VER=19 >> +USE_AUTOCONF_VER=259 > > The common style is to place tab after '='. Noted. I had a 50/50 chance of picking that one and while most of the options pushing their values another tab stop along don't use this style, my attempt to tidy the file up went the wrong way :) >> +%%NAGIOSWWWDIR%%/locale/de/LC_MESSAGES/nagios-plugins.mo >> +%%NAGIOSWWWDIR%%/locale/fr/LC_MESSAGES/nagios-plugins.mo > > What is a weird idea to place locale files in www dir? The effect of the --datadir configure argument is not consistent across both the nagios and nagios-plugins ports which is my bad for not picking up on that earlier. The changes required are then only required to the nagios port. I have updated the diff at the URL mentioned in the PR. Jarrod.
Comment 4 Sergey Matveychuk 2005-11-01 13:37:44 UTC
State Changed From-To: open->closed Committed, thanks!