Bug 88454

Summary: [patch] Porter's Handbook: Update sec. on Shared Libraries
Product: Documentation Reporter: Volker Stolz <vs>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
shlibs.diff none

Description Volker Stolz freebsd_committer freebsd_triage 2005-11-03 14:30:12 UTC 
Clarify unexpected consequences of setting LDCONFIG_DIRS.
Please review, I hope I got the markup right (compiling works).
Comment 1 Simon L. B. Nielsen freebsd_committer freebsd_triage 2005-11-03 19:28:02 UTC 
On 2005.11.03 15:26:04 +0100, Volker Stolz wrote:

> --- shlibs.diff begins here ---
> Index: book.sgml
> ===================================================================
> RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
> retrieving revision 1.625
> diff -u -u -r1.625 book.sgml
> --- book.sgml	2 Nov 2005 21:43:56 -0000	1.625
> +++ book.sgml	3 Nov 2005 14:22:43 -0000
> @@ -3869,6 +3869,16 @@
>  	<programlisting>INSTALLS_SHLIB= yes
>  LDCONFIG_DIRS=  %%PREFIX%%/lib/foo %%PREFIX%%/lib/bar</programlisting>
>  
> +	<para>Remember that non-standard directories will not be passed to


I would suggest "Note that" instead.  Just sounds better IMO.

> +	  <literal>/sbin/ldconfig</literal> on a reboot! If any port really


You should use &man.ldconfig.8; instead of <literal>/...</literal>.
Also I would suggest simply saying "boot" instead of "reboot".  Also
you should use double space before new sentence (IE. after the "!").

> +	  needs this to work, install a startup-script as
> +	  <literal>x11/kdelibs3</literal> does. Please double-check, often


Use <filename role="package">x11/kdelibs3</filename> and double space
after ".".

> +	  this is not necessary at all or can be avoided through
> +	  <literal>-rpath</literal> or setting <makevar>LD_RUN_PATH</makevar>


Since LD_LIBRARY_PATH is an environment variable you should use <envar>.

> +	  during linking (see <literal>lang/moscow_ml</literal> for an example),


<filename role="package"> again.

> +	  or through a shell-wrapper which sets <makevar>LD_LIBRARY_PATH</makevar>
> +	  before invoking the binary, like <literal>www/mozilla</literal> does.</para>


<filename role="package"> again.

Hope this helps.

-- 
Simon L. Nielsen
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2005-11-04 09:20:18 UTC 
State Changed
From-To: open->closed

Committed with modifications as suggested.