Bug 88546

Summary: Add a check for a period in IGNORE lines in portlint
Product: Ports & Packages Reporter: Anton Berezin <tobez>
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
patch-portlint
none
patch-portlint none

Description Anton Berezin freebsd_committer freebsd_triage 2005-11-06 10:40:11 UTC
Given an IGNORE string like this:

IGNORE=         requires perl 5.6 or above.

The following output is produced by make:

===>  p5-XXX-Y.Z requires perl 5.6 or above..

This double-dot is not nice, so it seems reasonable to
teach portlint to deal with it.
Comment 1 Anton Berezin freebsd_committer freebsd_triage 2005-11-06 10:45:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Assign this PR to the port maintainer.
Comment 2 Sam Lawrance 2005-11-12 02:20:03 UTC
Here's another patch
- check for correct capitalisation
- check for trailing period using a more simple expression

It doesn't allow for trailing whitespace, since another check already  
does that.  I also removed the /m modifier, it didn't seem right.

Comment 3 Sam Lawrance 2005-11-12 03:18:09 UTC
Let's pretend I didn't send that last patch.  It was very bogus.   
Here's a better one.
Comment 4 Sam Lawrance 2005-11-12 03:19:39 UTC
On 12/11/2005, at 2:18 PM, Sam Lawrance wrote:

> Let's pretend I didn't send that last patch.  It was very bogus.   
> Here's a better one.

Argh.  The patch...
Comment 5 Joe Marcus Clarke freebsd_committer freebsd_triage 2005-11-21 16:53:35 UTC
State Changed
From-To: open->closed

Committed, thanks!