Bug 89329

Summary: Add WCCPv2 support to squid
Product: Ports & Packages Reporter: Rauf Kuliyev <rauf>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
squid_wccpv2.patch none

Description Rauf Kuliyev 2005-11-20 21:50:15 UTC
              Add WCCP version 2 support to squid based on http://www.univ.kiev.ua/~roman/wccpv2/

Fix: The patch:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-21 23:17:12 UTC
Maintainer of www/squid,

Please note that PR ports/89329 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/89329

-- 
Edwin Groothuis
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-21 23:17:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Thomas-Martin Seck 2005-11-23 22:17:35 UTC
* Edwin Groothuis (edwin@FreeBSD.org):

I'm sorry, I cannot approve this patch.

The WCCP patch contained in it is substantially different in
functionality from the (seemingly abondoned) "official" WCCPv2 patch
originally created by Visolve.  I am neither able to verify it's
correctness nor am I able to maintain it in case it contains errors or
breaks things. It will thus bitrot very soon. (The Visolve WCCPv2 patch
that can be fetched from cvs.devel.squid-cache.org has bitrotted
severely in the meantime.)

I suggest that the submitter asks the squid developers whether there is
any interest in reviving the WCCPv2 project on devel.squid-cache.org
based on the work done at the Kiev university.

If there is sufficient interest from our users for this project and if
it is actively supported by the squid developers, I will seriously
consider adding it into the port. (ICAP is on my to-do list as well.)

(Additionally, I was not able to make the patched port survive a
"make patch" using the raw PR as input for patch(1) -- 
in the patch phase patch(1)  complained about malformed patches in
files/patch-wccpv2 very early on.  This is probably caused by whitespace
mangling but I did not have time to investigate too far.)
Comment 4 Rauf Kuliyev 2005-11-24 03:02:32 UTC
Correct patch is attached.
Comment 5 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-25 06:37:35 UTC
Maintainer of www/squid,

Please note that PR ports/89329 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/89329

-- 
Edwin Groothuis
edwin@FreeBSD.org
Comment 6 Florent Thoumie freebsd_committer freebsd_triage 2005-11-30 19:44:32 UTC
State Changed
From-To: feedback->closed

Maintainer didn't approve the patch.