Summary: | New Port: comms/uird, the Universal IR Receiver Daemon | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | David Thiel <lx> | ||||
Component: | Individual Port(s) | Assignee: | Emanuel Haupt <ehaupt> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
David Thiel
2005-11-22 04:30:27 UTC
Responsible Changed From-To: freebsd-ports-bugs->ehaupt Take. - the port does not respect CC [1] / CFLAGS [2] - could you please make pkg-plist a bit more PHB compliant [3] [1] http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-cc.html [2] http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-cflags.html [3] http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-desc.html#AEN82 State Changed From-To: open->feedback Ask for maintainer fix. On Tue, Nov 22, 2005 at 03:26:04PM +0100, Emanuel Haupt wrote: > - the port does not respect CC [1] / CFLAGS [2] Ah, you're right. I'll fix. > - could you please make pkg-plist a bit more PHB compliant [3] I'm not sure what you mean - I'm just making the plist in the Makefile itself, and it seems to clean up after itself. Thanks, David Ok, here's the fix for CFLAGS/CC. I can't find anything wrong with the plist, it seems to be compliant with the PHB. Please advise. diff -ruN uird.old/Makefile uird/Makefile --- uird.old/Makefile Tue Nov 22 09:41:25 2005 +++ uird/Makefile Tue Nov 22 09:46:03 2005 @@ -19,9 +19,13 @@ USE_GMAKE= yes USE_PERL5= yes +USE_REINPLACE= yes PLIST_FILES= bin/uird PORTDOCS= Documentation + +pre-build: + @${REINPLACE_CMD} -e "s|gcc|${CC} ${CFLAGS}|g" ${WRKSRC}/Makefile do-install: ${INSTALL_PROGRAM} ${WRKSRC}/uird ${PREFIX}/bin You seem to have copy/pasted everything 1:1 from the project website which contains a bit too much information for pkg-descr. The formatting is IMHO not "optimal" either. What do you think about the following version of pkg-descr: --- pkg-descr counter-proposal begins here --- UIRD is designed to interface with the UIRR (Universal IR Receiver) which is a piece of hardware that you can easily build yourself. Features: * Embedded perl-interpreter for advanced scripting features * Learning mode - interactively press a button on your remote and then enter what should happend every time you push that button * Simple configuration-file for specifying what should happen when you push a particular button * Network mode sends IR-data encapsulated in UDP-packets over the network to a remote host WWW: http://vvv.purjo.nu/uird/ --- pkg-descr counter-proposal ends here --- Ah, so you did mean pkg-descr. :) What you sent looks fine to me, but I would suggest that the first bit be: UIRD is software to control your PC via a normal remote control. It is designed to interface with the UIRR(Universal IR Receiver), which is a piece of hardware that you can easily build yourself. I think the part saying that you can use a normal remote to control a PC communicates what it does most effectively, and then goes into slightly more detail. Thanks, David State Changed From-To: feedback->closed New port added. Thanks! |