Bug 90042
| Summary: | [patch] acpi(4) should mention that ACPI_DEBUG depends on DDB. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Documentation | Reporter: | Wojciech A. Koszek <dunstan> | ||||
| Component: | Books & Articles | Assignee: | Wojciech A. Koszek <wkoszek> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Wojciech A. Koszek
2005-12-06 19:00:16 UTC
On 2005-12-06 19:00, "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> wrote: > System: FreeBSD laptop.freebsd.czest.pl 7.0-CURRENT FreeBSD 7.0-CURRENT #0: \ > Tue Dec 6 19:19:23 CET 2005 root@laptop.freebsd.czest.pl:/usr/obj/usr/src/sys/ACPITEST i386 > Please commit this patch or similar, since it must be documented somewhere > in basesystem. > diff -upr /usr/src/share/man/man4/acpi.4 src/share/man/man4/acpi.4 > --- /usr/src/share/man/man4/acpi.4 Fri Jul 15 19:35:25 2005 > +++ src/share/man/man4/acpi.4 Tue Dec 6 19:45:34 2005 > @@ -35,6 +35,7 @@ > .Cd "device acpi" > .Pp > .Cd "options ACPI_DEBUG" > +.Cd "options DDB" Is "DDB" really necessary though? I thought that ACPI_DEBUG only controls the amount of debugging messages printed to the system console; with or without a kernel debugger. On wto, lut 28, 2006 at 02:18:42 +0200, Giorgos Keramidas wrote: > To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> > Cc: bug-followup@freebsd.org > From: Giorgos Keramidas <keramida@freebsd.org> > Date: Tue, 28 Feb 2006 14:18:42 +0200 > Subject: Re: docs/90042: acpi.4 should mention that ACPI_DEBUG depends on DDB. > > On 2005-12-06 19:00, "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> wrote: > >> System: FreeBSD laptop.freebsd.czest.pl 7.0-CURRENT FreeBSD 7.0-CURRENT #0: \ >> Tue Dec 6 19:19:23 CET 2005 root@laptop.freebsd.czest.pl:/usr/obj/usr/src/sys/ACPITEST i386 > >> Please commit this patch or similar, since it must be documented somewhere >> in basesystem. > >> diff -upr /usr/src/share/man/man4/acpi.4 src/share/man/man4/acpi.4 >> --- /usr/src/share/man/man4/acpi.4 Fri Jul 15 19:35:25 2005 >> +++ src/share/man/man4/acpi.4 Tue Dec 6 19:45:34 2005 >> @@ -35,6 +35,7 @@ >> .Cd "device acpi" >> .Pp >> .Cd "options ACPI_DEBUG" >> +.Cd "options DDB" > > Is "DDB" really necessary though? I thought that ACPI_DEBUG only controls > the amount of debugging messages printed to the system console; with or > without a kernel debugger. Giorgos, You're right. Although this report is faked, problem reported here is quite different -- with ACPI_DEBUG but without DDB, produced acpi.ko has unresolved symbol: AcpiDmDumpMethodInfo. Some #ifdef's are probably missing. cognet@ suggested to let njl@ know about it. Thus, I'm putting him in CC. Once this bug is fixed, I'll close my PR. Thanks, -- Wojciech A. Koszek wkoszek@FreeBSD.org http://FreeBSD.czest.pl/dunstan/ Wojciech A. Koszek wrote:
> On wto, lut 28, 2006 at 02:18:42 +0200, Giorgos Keramidas wrote:
>> To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
>> Cc: bug-followup@freebsd.org
>> From: Giorgos Keramidas <keramida@freebsd.org>
>> Date: Tue, 28 Feb 2006 14:18:42 +0200
>> Subject: Re: docs/90042: acpi.4 should mention that ACPI_DEBUG depends on DDB.
>>
>> On 2005-12-06 19:00, "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> wrote:
>>
>>> System: FreeBSD laptop.freebsd.czest.pl 7.0-CURRENT FreeBSD 7.0-CURRENT #0: \
>>> Tue Dec 6 19:19:23 CET 2005 root@laptop.freebsd.czest.pl:/usr/obj/usr/src/sys/ACPITEST i386
>>> Please commit this patch or similar, since it must be documented somewhere
>>> in basesystem.
>>> diff -upr /usr/src/share/man/man4/acpi.4 src/share/man/man4/acpi.4
>>> --- /usr/src/share/man/man4/acpi.4 Fri Jul 15 19:35:25 2005
>>> +++ src/share/man/man4/acpi.4 Tue Dec 6 19:45:34 2005
>>> @@ -35,6 +35,7 @@
>>> .Cd "device acpi"
>>> .Pp
>>> .Cd "options ACPI_DEBUG"
>>> +.Cd "options DDB"
>> Is "DDB" really necessary though? I thought that ACPI_DEBUG only controls
>> the amount of debugging messages printed to the system console; with or
>> without a kernel debugger.
>
> Giorgos,
>
> You're right. Although this report is faked, problem reported here is quite different --
> with ACPI_DEBUG but without DDB, produced acpi.ko has unresolved symbol:
> AcpiDmDumpMethodInfo. Some #ifdef's are probably missing.
>
> cognet@ suggested to let njl@ know about it. Thus, I'm putting him in CC.
> Once this bug is fixed, I'll close my PR.
ACPI has a built-in debugger when ACPI_DEBUG is defined. You do need
options DDB when compiling with it. I think the manpage update is fine.
--
Nate
Responsible Changed From-To: freebsd-doc->wkoszek Take this one. State Changed From-To: open->closed Fix was commited to -HEAD. I'm hoping to see it MFCed after 3 days. |
