Bug 90515

Summary: Use new patch naming convention in Porter's Handbook
Product: Documentation Reporter: Gabor Kovesdan <gabor.kovesdan>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me CC: gabor.kovesdan
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
book.sgml.diff none

Description Gabor Kovesdan 2005-12-16 20:30:03 UTC 
According to http://wikitest.freebsd.org/moin.cgi/PortsLongtermTargets the new
patch naming convention requires to use :: signs for specifying paths in the
patch filenames, e.g. patch-src::config.c, but Porter's Handbook describes the
old naming convention, e.g. patch-src-config.c.
This patch updates Porter's Handbook to explain the new rule.
Comment 1 Mark Linimon 2005-12-16 21:10:19 UTC 
On Fri, Dec 16, 2005 at 09:29:33PM +0100, Gabor Kovesdan wrote:
> According to http://wikitest.freebsd.org/moin.cgi/PortsLongtermTargets the new
> patch naming convention requires to use :: signs for specifying paths in the
> patch filenames, e.g. patch-src::config.c, but Porter's Handbook describes the
> old naming convention, e.g. patch-src-config.c.

Then the wiki is wrong.  The Porter's Handbook is correct.

Is the other part of your change still relevant even with this being the case?
Comment 2 Gabor Kovesdan 2005-12-16 21:12:48 UTC 
Mark Linimon wrote:

>On Fri, Dec 16, 2005 at 09:29:33PM +0100, Gabor Kovesdan wrote:
>  
>
>>According to http://wikitest.freebsd.org/moin.cgi/PortsLongtermTargets the new
>>patch naming convention requires to use :: signs for specifying paths in the
>>patch filenames, e.g. patch-src::config.c, but Porter's Handbook describes the
>>old naming convention, e.g. patch-src-config.c.
>>    
>>
>
>Then the wiki is wrong.  The Porter's Handbook is correct.
>
>Is the other part of your change still relevant even with this being the case?
>  
>
No. So, if I make a port, I should use the patch-src-config.c form 
instead of patch-src::config.c?
Comment 3 Mark Linimon 2005-12-16 21:19:23 UTC 
On Fri, Dec 16, 2005 at 10:12:48PM +0100, Kövesdán Gábor wrote:
> No. So, if I make a port, I should use the patch-src-config.c form 
> instead of patch-src::config.c?

Correct.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2005-12-17 01:11:00 UTC 
State Changed
From-To: open->closed

Oh you got it backwards. :: is old way and should not be used for new work. 
The wiki page is merely tracking a progress of getting rid of ::'s. 
The text in the header is a longterm target of "not using :: in patchfile name".