Bug 90719

Summary: [patch] multimedia/vlc fails to build with firefox-plugin
Product: Ports & Packages Reporter: Raaf <raaf>
Component: Individual Port(s)Assignee: Michael Johnson <ahze>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Raaf 2005-12-20 22:20:02 UTC
If you have WITH_MOZILLA= firefox and WITH_MOZILLA_PLUGIN= yes
defined multimedia/vlc fails to build.

Fix: Latest firefox has idl files in ${X11BASE}/share/idl/firefox-1.5 while
vlc Makefile has hardcoded path to ${X11BASE}/share/idl/firefox.

There doesn't seem to be a need (anymore) to define XPIDL_INCL,
i think following line of configure.ac now takes care of idl path:

AS_IF([test "${MOZILLA_CONFIG}"], [
  if test -z "${XPIDL_INCL}"; then
     XPIDL_INCL="`${MOZILLA_CONFIG} --cflags plugin xpcom java` \
     `${MOZILLA_CONFIG} --idlflags plugin xpcom java` "
  fi
])
	    
Anyway with following patch vlc builds fine:
How-To-Repeat: 
Build multimedia/vlc WITH_MOZILLA= firefox and WITH_MOZILLA_PLUGIN= yes

[...]

Making all in mozilla
gmake[2]: Entering directory `/usr/ports/multimedia/vlc/work/vlc-0.8.4/mozilla'
/usr/X11R6/lib/firefox/xpidl -I/usr/X11R6/share/idl/firefox \
  -m header -o vlcintf ./vlcintf.idl
    ./vlcintf.idl:3: can't open included file nsISupports.idl for reading

input callback returned failure
gmake[2]: *** [vlcintf.h] Error 2
gmake[2]: Leaving directory `/usr/ports/multimedia/vlc/work/vlc-0.8.4/mozilla'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/multimedia/vlc/work/vlc-0.8.4'
gmake: *** [all] Error 2
*** Error code 2

Stop in /usr/ports/multimedia/vlc.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2005-12-20 22:21:42 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ahze

Over to maintainer
Comment 2 Michael Johnson freebsd_committer freebsd_triage 2006-01-08 14:27:45 UTC
State Changed
From-To: open->closed

Fixed, thanks!