Bug 90847

Summary: [PATCH] security/p5-Digest-DMAC: unbreak on old perl
Product: Ports & Packages Reporter: Yen-Ming Lee <leeym>
Component: Individual Port(s)Assignee: Yen-Ming Lee <leeym>
Status: Closed FIXED    
Severity: Affects Only Me CC: gkovesdan
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
p5-Digest-DMAC-1.1.4.patch none

Description Yen-Ming Lee freebsd_committer freebsd_triage 2005-12-23 10:50:05 UTC 
- unbreak this port on old perl

Port maintainer (gkovesdan@t-hosting.hu) is cc'd.

Generated with FreeBSD Port Tools 0.63
Comment 1 Yen-Ming Lee freebsd_committer freebsd_triage 2005-12-23 10:51:13 UTC 
State Changed
From-To: open->feedback

The maintainer is noticed.
Comment 2 Yen-Ming Lee freebsd_committer freebsd_triage 2005-12-23 10:51:16 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->leeym

I will take care of this PR.
Comment 3 Gabor Kovesdan 2005-12-23 11:02:54 UTC 
Thanks, I approve. Please do a PORTREVISION bump, too, since the 
install-time behaviour has been changed.

As for RUN_DEPENDS= ${BUILD_DEPENDS}, it means that RUN_DEPENDS will 
always be the same as BUILD_DEPENDS? Or is it just a simple 
substitution? I mean, don't we have to put an another RUN_DEPENDS= 
${BUILD_DEPENDS} line after BUILD_DEPENDS+= 
${SITE_PERL}/Test/More.pm:${PORTSDIR}/devel/p5-Test-Simple?

Regards,
Gabor Kovesdan
Comment 4 Yen-Ming Lee freebsd_committer freebsd_triage 2005-12-23 11:53:29 UTC 
On Fri, Dec 23, 2005 at 12:02:54PM +0100, Kövesdán Gábor wrote:
> Thanks, I approve. Please do a PORTREVISION bump, too, since the 
> install-time behaviour has been changed.

According to section 5.2.2.1 in FreeBSD porter handbook, it doesn't
require a PORTREVISION bump.

- Build fixes which cause a package to become compilable where it was previously failing

The patch only change the behavior when PERL_LEVEL < 500600, and it's marked
IGNORE previously, so the package was not previously buildable then there is
no need to increase PORTREVISION to mark a change.

> As for RUN_DEPENDS= ${BUILD_DEPENDS}, it means that RUN_DEPENDS will 
> always be the same as BUILD_DEPENDS? Or is it just a simple 
> substitution? I mean, don't we have to put an another RUN_DEPENDS= 
> ${BUILD_DEPENDS} line after BUILD_DEPENDS+= 
> ${SITE_PERL}/Test/More.pm:${PORTSDIR}/devel/p5-Test-Simple?

I tested it under old perl, and BUILD_DEPENDS always equals to RUN_DEPENDS.

p5-Test-Simple is needed if you want to "make test", and FreeBSD ports
don't do "make test" when building packages.

Yes, we don't have to put BUILD_DEPENDS+=p5-Test-Simple. I'll remove it.

-- 
Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan
Comment 5 Yen-Ming Lee freebsd_committer freebsd_triage 2005-12-23 17:45:55 UTC 
State Changed
From-To: feedback->closed

Committed, thanks.