Bug 90904

Summary: zope startup script need modification to handle the new "faststart" option
Product: Ports & Packages Reporter: Palle Girgensohn <girgen>
Component: Individual Port(s)Assignee: Palle Girgensohn <girgen>
Status: Closed FIXED    
Severity: Affects Only Me CC: estartu
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
d none

Description Palle Girgensohn freebsd_committer freebsd_triage 2005-12-25 21:00:14 UTC 
The rc.subr was recently changed, and now the argument is "faststart"
when booting the OS. The zope.sh and zeo.sh startup scripts need to be
modified to handle this.

How-To-Repeat: Update system (or rc.subr port for FreeBSD 4.x) and reboot. Zope will
not start, complaining that the startup script does not understand the
"faststart" argument.
Comment 1 Palle Girgensohn freebsd_committer freebsd_triage 2005-12-25 21:04:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->girgen
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2005-12-25 21:06:14 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Palle Girgensohn freebsd_committer freebsd_triage 2005-12-25 21:27:09 UTC 
Here's a suggested patch that works fine for me.

estartu, is it OK that I commit this? I will need to bump portrevision.

/Palle
Comment 4 Palle Girgensohn freebsd_committer freebsd_triage 2005-12-25 21:35:38 UTC 
And of course, the zeo.sh script must also be handled in the same way:

#!/bin/sh

# Start or stop zope
# $FreeBSD: ports/www/zope/files/zeo.sh,v 1.2 2005/02/18 16:52:17 pav Exp $

# PROVIDE: zeo
# REQUIRE: DAEMON
# BEFORE: zope
# KEYWORD: FreeBSD shutdown
#
prefix=%%PREFIX%%

# Define these zope_* variables in one of these files:
#       /etc/rc.conf
#       /etc/rc.conf.local
#       /etc/rc.conf.d/zeo
#
# DO NOT CHANGE THESE DEFAULT VALUES HERE
#
zeo_enable=${zeo_enable:-"NO"}        # Enable zeo server
zeo_instances=${zeo_instances:-""}    # List of instancehome dirs

. %%RC_SUBR%%

name="zeo"
rcvar=`set_rcvar`
load_rc_config $name
extra_commands="status"

if checkyesno zeo_enable; then
    for instance in $zeo_instances; do
	required_files="${instance}/etc/${name}.conf ${instance}/bin/zeoctl"
	zeo_command="${instance}/bin/zeoctl"
	start_cmd="${zeo_command} start"
	stop_cmd="${zeo_command} stop"
	restart_cmd="${zeo_command} restart"
	status_cmd="${zeo_command} status"
	echo -n "Zeo instance ${instance} -> "
	run_rc_command "$1"
    done
fi
Comment 5 Palle Girgensohn freebsd_committer freebsd_triage 2005-12-25 21:37:57 UTC 
mailer broke som diffs, so I've put them here:

http://people.freebsd.org/~girgen/zope.diff

/Palle
Comment 6 Gerhard Schmidt 2005-12-28 16:17:58 UTC 
I approve this patch. Thanks for the work Palle

Bye
	Estartu
Comment 7 Palle Girgensohn freebsd_committer freebsd_triage 2005-12-30 23:37:51 UTC 
State Changed
From-To: feedback->closed

You're welcome! Committed. :)