Bug 91024

Summary: [maintainer update] security/ipfcount incorrectly checks Perl version
Product: Ports & Packages Reporter: Robert Archer <freebsd>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Robert Archer 2005-12-28 17:10:03 UTC
	In the port's Makefile, a check is made for Perl 5.6 or greater. Due to
	incorrect handling of PERL_LEVEL, this check will always succeed.

	As a result, users of 4.x will be able to install the port using the
	version of Perl in the base system, but will not be able to run it.

	Thanks to Jarrod Sayers <jarrod@netleader.com.au> for spotting this.


Patch is at http://deathbeforedecaf.net/misc/patches/ipfcount.2005-12-29

	diff -ruN ipfcount.2005-12-29/Makefile ipfcount/Makefile
	--- ipfcount.2005-12-29/Makefile	Thu Dec 22 22:25:14 2005
	+++ ipfcount/Makefile	Thu Dec 29 01:57:54 2005
	@@ -7,6 +7,7 @@
	 PORTNAME=	ipfcount
	 CATEGORIES=	security
	 MASTER_SITES=	http://deathbeforedecaf.net/misc/ports/ \
	@@ -27,7 +28,7 @@
	 .include <bsd.port.pre.mk>
	-.if ${PERL_LEVEL} < 5006
	+.if ${PERL_LEVEL} < 500600
	 IGNORE=		requires perl 5.6 or higher - see the lang/perl5.8 port
How-To-Repeat: 	builder# make -V PERL_LEVEL
	builder# ipfcount
	Perl 5.006 required--this is only version 5.00503, stopped at /usr/local/bin/ipfcount line 13.
	BEGIN failed--compilation aborted at /usr/local/bin/ipfcount line 13.
Comment 1 Erwin Lansing freebsd_committer 2005-12-28 17:46:23 UTC
State Changed
From-To: open->closed

Committed, thanks!