Bug 91757
| Summary: | /usr/ports/sysutils/fastest_cvsup Suggested enhancement | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Doug Poland <doug> |
| Component: | Individual Port(s) | Assignee: | Emanuel Haupt <ehaupt> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-ports-bugs->ehaupt Take. State Changed From-To: open->closed Committed, thanks! |
The display of the fastest 3 cvsup servers shows only ranking, and server name. It would be nice to know the speed of the server without having to scroll back up the page. I've included a patch to do just that. Fix: Patch was tested on i386, 5.2.1-RELEASE and 6.0-STABLE. --- fastest_cvsup 2006/01/13 13:24:38 1.1 +++ fastest_cvsup 2006/01/13 13:43:08 @@ -526,9 +526,9 @@ if ( $VERBOSE ) { # print pretty display - my $ms = sprintf("%.2f", 1000 * $time_taken); # time in ms + $time{$server} = 1000 * $time_taken ; # time in ms print $SERVER_RESULT, "server replied: $reply\n"; - print $SERVER_RESULT, "time taken: $ms ms\n"; + print $SERVER_RESULT, "time taken: " . sprintf("%.2f",$time{$server}) . " ms\n"; } } @@ -547,9 +547,9 @@ if ( $VERBOSE ) { print "\n", $GENERAL_INFO, "Speed Daemons:\n" if $fastest[0]; # just checking ;) - print $SERVER_RESULT, "1st: $fastest[0]\n" if $fastest[0]; - print $SERVER_RESULT, "2nd: $fastest[1]\n" if $fastest[1]; - print $SERVER_RESULT, "3rd: $fastest[2]\n" if $fastest[2]; + printf("%s1st: %-24s %.2f ms\n", $SERVER_RESULT, $fastest[0], $time{$fastest[0]}) if $fastest[0]; + printf("%s2st: %-24s %.2f ms\n", $SERVER_RESULT, $fastest[1], $time{$fastest[1]}) if $fastest[1]; + printf("%s3st: %-24s %.2f ms\n", $SERVER_RESULT, $fastest[2], $time{$fastest[2]}) if $fastest[2]; } else { # otherwise just output the fastest. print $fastest[0]; How-To-Repeat: Display of the fastest 3 cvsup servers is the default. My patch modifies the default output.