Bug 92202
| Summary: | New port: www/dokeos Dokeos | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Filipe Rocha <filiperocha> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Aaron Dalton <aaron> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | ||||||||||||
| Priority: | Normal | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Filipe Rocha
2006-01-23 13:40:05 UTC
Responsible Changed From-To: freebsd-ports-bugs->aaron Take. State Changed From-To: open->feedback Ask for submitter fix. Hi, Filipe! A couple of things please. 1) There is no need to include the .tgz files themselves. The shar is more than sufficient. 2) Shar files should be generated from the immediate parent directory. In your case you should: $ cd /usr/ports/www $ shar `find dokeos` > dokeos.shar Please regenerate your shar and resubmit it as a follow-up to this PR. There is no need to open a new PR. Thanks! -- Aaron Dalton aaron@FreeBSD.org FreeBSD Ports Committer Hi Aaron, I don't know if i'm doing this right. This is one of my first ports. Please tell if this is the right procedure, Thanks a lot, Filipe Hi there Aaron, I'd like to know if something went wrong with the previous followup. Thank you Filipe Rocha State Changed From-To: feedback->open Feedback received. I apologize for the extended delay. Life has been merciless. There are a couple of small issues with the updated shar: 1) distinfo is not accurate. I assume this is why problem 2 exists. 2) pkg-plist is incomplete. If I regen the distinfo for 1.6.3 I see language templates (apparently) missing for Korean, Latvian, Macedonian, Romanian, trad_chinese and a few other minor discrepancies. Please update this shar and resubmit it. Do not open a new pr!! Simply responding to this email should be sufficient. Cheers! -- Aaron Dalton aaron@FreeBSD.org FreeBSD Ports Committer State Changed From-To: open->feedback Ask for submitter fix. Hope it's ok now... I ran the shar file and next used "port test" (devel/porttools) and "portlint -A" and the traditional (porters-handbook) way to test it. Thank you, Filipe I'm sorry, Filipe, but the same problems exist with the new shar, namely: 1) The distinfo file is not matching the file downloaded from the master site. 2) The pkg-plist is still missing over 200 lines. Please visit section 7.5 of the Porter's Handbook (http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-autoplist.html) for information on how to do this automatically. 3) And finally, the following 2 lines do not belong in the pkg-plist: @dirrm share/nls/en_US.US-ASCII @dirrm share/nls/POSIX Please repair the errors and resubmit a new shar AS A REPLY TO THIS EMAIL. If you have any further questions, don't hesitate to contact me! Cheers! -- Aaron Dalton aaron@FreeBSD.org FreeBSD Ports Committer Hi Aaron, On Thursday 11 May 2006 22:11, you wrote: > I'm sorry, Filipe, but the same problems exist with the new shar, namely: > > 1) The distinfo file is not matching the file downloaded from the master > site. I already had the source on my distfiles looks like they changed it... :( and looks like I didn't understand what you meant on 1). I'm sorry! I went to dokeos homepage and saw a new release (which apparently 2.6.4 as the same size as 2.6.3 (didn't do a distinfo for 2.6.3). So I removed mine, updated Makefile to 2.6.4. > 2) The pkg-plist is still missing over 200 lines. Please visit section > 7.5 of the Porter's Handbook > (http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-au >toplist.html) for information on how to do this automatically. /usr/ports/Tools/scripts/plist to pkg-plist as in porters handbook > 3) And finally, the following 2 lines do not belong in the pkg-plist: > @dirrm share/nls/en_US.US-ASCII > @dirrm share/nls/POSIX removed :) > Please repair the errors and resubmit a new shar AS A REPLY TO THIS > EMAIL. If you have any further questions, don't hesitate to contact me! > > Cheers! I've tested it again, and and no chunks left on /usr/local/www from dokeos... I hope this one is finally done... I'm really sorry for taking you so much time. And I thank you for helping me on this one. Sincerely, Filipe State Changed From-To: feedback->open Feedback received. Filipe Rocha wrote: > > I've tested it again, and and no chunks left on /usr/local/www from dokeos... > I hope this one is finally done... > I'm really sorry for taking you so much time. And I thank you for helping me > on this one. > Sincerely, > Filipe > Looks good! All I had to do was remove the dokeos.shar stub that somehow ended up in the directory. There's no need to apologize. It is both my job and my pleasure to help get these submissions right. It takes time to learn the ropes. The port is being reviewed now by my mentor and should be committed soon. Cheers! -- Aaron Dalton aaron@FreeBSD.org FreeBSD Ports Committer State Changed From-To: open->closed New port added. Thanks! |
