Bug 92334

Summary:	Review of FreeBSD Port of Tcl
Product:	Ports & Packages	Reporter:	Donal Fellows <donal.k.fellows>
Component:	Individual Port(s)	Assignee:	Sam Lawrance <lawrance>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Donal Fellows 2006-01-25 23:40:03 UTC

I have been reviewing the patches to Tcl source files as part of the port of Tcl to FreeBSD (looking at http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/tcl84/files/) and I have some feedback.

 * patch-tclUnixChan.c - it is not really clear what this patch is attempting to do, but it is definitely not doing what its check in comment seems to indicate is attempted. FWIW, Tcl configures all FDs that satisfy the isatty() call as serial channels *except* stdin/stdout/stderr and explicitly /dev/tty (NB not /dev/ttya or anything else that has /dev/tty as a prefix; just the literal). My guess is that this patch can be dropped with no ill effect at all, given that asking around indicates that you don't have a device called "/dev/cua" (/dev/cuaa0 etc. not counting given the logic of that patch).

 * patch-tclUnixInit.c - this patch has been accepted into the Tcl core; it will form part of Tcl 8.4.11

 * patch-tclUnixSock.c - this patch seems to indicate that a better configure test for uname() is necessary, though I don't know what to do exactly there. In any case, I suspect that this patch is fixing things in the wrong place.

 * patch-aa,patch-configure - I've not reviewed these (they're for files that we pretty much expect vendors to adapt anyway)

How-To-Repeat: N/A

Comment 1 Sam Lawrance freebsd_committer

2006-04-16 06:30:23 UTC

Responsible Changed
From-To: freebsd-ports-bugs->lawrance

I'll handle it.

Comment 2 Sam Lawrance freebsd_committer

2006-04-29 15:48:00 UTC

State Changed
From-To: open->closed

Thanks very much for the review!  Here are the changes 
I made as a result: 

patch-tclUnixChan.c - I agree that this patch is bogus.  Removed. 

patch-tclUnixInit.c - Patch will remain until the port is updated to 
a version of Tcl which includes the patch.  Thanks for incorporating 
it into your source. 

patch-tclUnixSock.c - This patch was introduced on the premise that 
uname() only returned the first 32 characters of the nodename.  This 
is not the case now, so the patch was removed.