Bug 92410

Summary: calloc.c missing from Makefile.inc
Product: Base System Reporter: Bruce Becker <hostmaster>
Component: amd64Assignee: freebsd-amd64 (Nobody) <amd64>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   

Description Bruce Becker 2006-01-27 09:30:08 UTC
              
Make buildworld failed with missing reference to calloc at link of atrun

Fix: 

add "calloc.c" to MISRCS+= declaration in /usr/src/lib/libc/stdlib/Makefile.inc
(# $FreeBSD: src/lib/libc/stdlib/Makefile.inc,v 1.48.8.1 2006/01/27 05:17:25 trhodes Exp $)

-STABLE shouldn't ever have untested code in it :|
How-To-Repeat: make buildworld
Comment 1 Kris Kennaway 2006-01-27 09:57:56 UTC
On Fri, Jan 27, 2006 at 09:21:44AM +0000, Bruce Becker wrote:
> 
> >Number:         92410
> >Category:       amd64
> >Synopsis:       calloc.c missing from Makefile.inc
> >Confidential:   no
> >Severity:       critical
> >Priority:       high
> >Responsible:    freebsd-amd64
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Fri Jan 27 09:30:08 GMT 2006
> >Closed-Date:
> >Last-Modified:
> >Originator:     Bruce Becker
> >Release:        6.0
> >Organization:
> G.T.S.
> >Environment:
> FreeBSD vhcst.web.ca 6.0-STABLE FreeBSD 6.0-STABLE #0: Sun Jan 22 23:25:49 EST 2006     root@tarantula:/usr/obj/usr/src/sys/TARANTULA  amd64
> 
> >Description:
>               
> Make buildworld failed with missing reference to calloc at link of atrun


You omitted the error.  It's probably caused by something on your end,
since 6.0-STABLE in fact builds just fine.

> >How-To-Repeat:
> make buildworld
> >Fix:
> add "calloc.c" to MISRCS+= declaration in /usr/src/lib/libc/stdlib/Makefile.inc
> (# $FreeBSD: src/lib/libc/stdlib/Makefile.inc,v 1.48.8.1 2006/01/27 05:17:25 trhodes Exp $)
> 
> -STABLE shouldn't ever have untested code in it :|


If you say so :)

Kris
Comment 2 hostmaster 2006-01-27 17:15:23 UTC
Thus saith Kris Kennaway:
| 
| 
| --ZGiS0Q5IWpPtfppv
| Content-Type: text/plain; charset=us-ascii
| Content-Disposition: inline
| Content-Transfer-Encoding: quoted-printable
| 
| On Fri, Jan 27, 2006 at 09:21:44AM +0000, Bruce Becker wrote:
| >=20
| > >Number:         92410
| > >Category:       amd64
| > >Synopsis:       calloc.c missing from Makefile.inc
| > >Confidential:   no
| > >Severity:       critical
| > >Priority:       high
| > >Responsible:    freebsd-amd64
| > >State:          open
| > >Quarter:       =20
| > >Keywords:      =20
| > >Date-Required:
| > >Class:          sw-bug
| > >Submitter-Id:   current-users
| > >Arrival-Date:   Fri Jan 27 09:30:08 GMT 2006
| > >Closed-Date:
| > >Last-Modified:
| > >Originator:     Bruce Becker
| > >Release:        6.0
| > >Organization:
| > G.T.S.
| > >Environment:
| > FreeBSD vhcst.web.ca 6.0-STABLE FreeBSD 6.0-STABLE #0: Sun Jan 22 23:25:4=
| 9 EST 2006     root@tarantula:/usr/obj/usr/src/sys/TARANTULA  amd64
| >=20
| > >Description:
| >              =20
| > Make buildworld failed with missing reference to calloc at link of atrun
| 
| You omitted the error.  It's probably caused by something on your end,
| since 6.0-STABLE in fact builds just fine.


	It *definitely* was caused by a bad submission.  Maybe it's
	already been fixed?  Check the CVS history please - I have
	been building 6.0 amd64 versions from cvsup for days now -
	the version of /usr/src/lib/libc/stdlib/Makefile.inc checked in
	yesterday definitely broke things! (go look in the repository).


	PLEASE DO NOT SHOOT THE MESSENGER


| > >How-To-Repeat:
| > make buildworld
| > >Fix:
| > add "calloc.c" to MISRCS+=3D declaration in /usr/src/lib/libc/stdlib/Make=
| file.inc
| > (# $FreeBSD: src/lib/libc/stdlib/Makefile.inc,v 1.48.8.1 2006/01/27 05:17=
| :25 trhodes Exp $)
| >=20
| > -STABLE shouldn't ever have untested code in it :|
| 
| If you say so :)


	That was a very unpleasant problem to have to deal with
	at 4:30 AN when there's a deadline to meet...


-- 
Bruce Becker			+1 416 410 0879
GTS Network Administration	Toronto, Ont.
Email:	hostmaster@gts.net
Comment 3 hostmaster 2006-01-27 17:29:56 UTC
Forwarded message:
| From hostmaster Fri Jan 27 12:15:23 2006
| Subject: Re: amd64/92410: calloc.c missing from Makefile.inc
| To: kris@obsecurity.org (Kris Kennaway)
| Date: Fri, 27 Jan 2006 12:15:23 -0500 (EST)
| Thus saith Kris Kennaway:
| | On Fri, Jan 27, 2006 at 09:21:44AM +0000, Bruce Becker wrote:
| | >
| | > >Number:         92410
| | > >Category:       amd64
| | > >Synopsis:       calloc.c missing from Makefile.inc
| | > >Confidential:   no
| | > >Severity:       critical
| | > >Priority:       high
| | > >Responsible:    freebsd-amd64
| | > >State:          open
| | > >Quarter:       
| | > >Keywords:      
| | > >Date-Required:
| | > >Class:          sw-bug
| | > >Submitter-Id:   current-users
| | > >Arrival-Date:   Fri Jan 27 09:30:08 GMT 2006
| | > >Closed-Date:
| | > >Last-Modified:
| | > >Originator:     Bruce Becker
| | > >Release:        6.0
| | > >Organization:   G.T.S.
| | > >Environment:
| | > FreeBSD vhcst.web.ca 6.0-STABLE FreeBSD 6.0-STABLE #0: Sun Jan 22 23:25:4=
| | 9 EST 2006     root@tarantula:/usr/obj/usr/src/sys/TARANTULA  amd64
| | >=20
| | > >Description:
| | >              =20
| | > Make buildworld failed with missing reference to calloc at link of atrun
| | 
| | You omitted the error.  It's probably caused by something on your end,
| | since 6.0-STABLE in fact builds just fine.
| 
| 	It *definitely* was caused by a bad submission.  Maybe it's
| 	already been fixed?  Check the CVS history please - I have
| 	been building 6.0 amd64 versions from cvsup for days now -
| 	the version of /usr/src/lib/libc/stdlib/Makefile.inc checked in
| 	yesterday definitely broke things! (go look in the repository).
| 
| 	PLEASE DO NOT SHOOT THE MESSENGER
| 
| | > >How-To-Repeat:
| | > make buildworld
| | > >Fix:
| | > add "calloc.c" to MISRCS+=3D declaration in /usr/src/lib/libc/stdlib/Make=
| | file.inc
| | > (# $FreeBSD: src/lib/libc/stdlib/Makefile.inc,v 1.48.8.1 2006/01/27 05:17=
| | :25 trhodes Exp $)
| | >=20
| | > -STABLE shouldn't ever have untested code in it :|
| | 
| | If you say so :)
| 
| 
| 	That was a very unpleasant problem to have to deal with
| 	at 4:30 AN when there's a deadline to meet...


	FYI - please see PR 94210 - I just looked in the CVS to see
	that this issue was related to PR 51209 (thanks for adding
	the functionality in any case)


Thanks,
Bruce Becker			+1 416 410 0879
GTS Network Administration	Toronto, Ont.
Email:	hostmaster@gts.net
Comment 4 Tom Rhodes freebsd_committer freebsd_triage 2006-01-31 16:32:47 UTC
State Changed
From-To: open->closed

Fixed mismerge, thanks!