Bug 92474

Summary: [patch] fix for the xsl template
Product: Documentation Reporter: Daniel Gerzo <danger>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
includes.header.xsl.diff none

Description Daniel Gerzo 2006-01-28 22:10:02 UTC 
the current www/share/sgml/includes.header.xsl is buggy, since the "if"
statement is wrong there according to the comment in the
www/share/sgml/includes.release.xsl file which says: 

"An upcoming release that we want tested.  Set $beta.testing to 0
if we're not in the middle of a release cycle.  Ha ha."

As we are not in the middle of RC (and the $beta.testing is set to '0'),
the web pages generated from xsl are still containing URLs for 6.0-RC1
because of this wrong "if".

Fix: Use this patch:
How-To-Repeat: check some web page generated from xsl template including links to the
release/download menu
Comment 1 Ceri Davies 2006-02-05 00:20:35 UTC 
On 28 Jan 2006, at 22:09, Daniel Gerzo wrote:

> As we are not in the middle of RC (and the $beta.testing is set to  
> '0'),
> the web pages generated from xsl are still containing URLs for 6.0-RC1
> because of this wrong "if".

Can you give an example?  I've just checked the two pages that use  
this code and they look fine.

Ceri
Comment 2 Daniel Gerzo 2006-02-05 10:38:33 UTC 
Hello Ceri,

Sunday, February 5, 2006, 1:20:35 AM, you wrote:

> On 28 Jan 2006, at 22:09, Daniel Gerzo wrote:

>> As we are not in the middle of RC (and the $beta.testing is set to  
>> '0'),
>> the web pages generated from xsl are still containing URLs for 6.0-RC1
>> because of this wrong "if".

> Can you give an example?  I've just checked the two pages that use  
> this code and they look fine.

if the xsl template uses this:
<xsl:variable name="section" select="'download'"/>

then you can see the bug, but actually I wasn't able to find any page
which uses this currently. I found this bug when I was XML'ifying the
release todo list.

> Ceri

-- 
Sincerely,
   Daniel Gerzo
Comment 3 Ceri Davies freebsd_committer freebsd_triage 2006-02-05 12:14:14 UTC 
State Changed
From-To: open->closed

Good catch.  Cheers.