Bug 93050

Summary: unbreak and update biology/t_coffee
Product: Ports & Packages Reporter: Fernan Aguero <fernan>
Component: Individual Port(s)Assignee: Sam Lawrance <lawrance>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
t_coffee.diff
none
t_coffee.diff none

Description Fernan Aguero 2006-02-08 19:10:06 UTC 
	
	
	
	i. build fails on gcc-3.4 (base gcc in FreeBSD-6.0) but not on
	gcc-3.3 (USE_GCC=3.3, FreeBSD-6.0) or on gcc-2.95 (base gcc in
	FreeBSD-4.11).  The problem is an internal compiler error, the
	software author has been notified and while we wait for a
	resolution, the proposed fix is to just USE_GCC=3.3 For this we
	have to also patch the t_coffee Makefile, as it is hardcoding
	cc.
	
	ii. I also take the opportunity to update the port to the latest
	version. The issue reported in (i) occurs in both the old (3.18)
	and the new (3.27) t_coffe, as well as in a development version
	provided by the author.
Comment 1 Sam Lawrance freebsd_committer freebsd_triage 2006-02-09 02:26:03 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lawrance

Nab this PR
Comment 2 Sam Lawrance freebsd_committer freebsd_triage 2006-02-09 10:03:40 UTC 
State Changed
From-To: open->feedback

Out of date checksum.  Have you tested this update? 

====================<phase 1: make checksum>==================== 
=> T-COFFEE_distribution_Version_3.27.tar.gz is not in /a/ports/biology/t_coffee/distinfo. 
=> Either /a/ports/biology/t_coffee/distinfo is out of date, or 
=> T-COFFEE_distribution_Version_3.27.tar.gz is spelled incorrectly. 
*** Error code 1 

Stop in /a/ports/biology/t_coffee.
Comment 3 Fernan Aguero 2006-02-09 14:11:52 UTC 
+----[ Sam Lawrance <lawrance@FreeBSD.org> (09.Feb.2006 07:07):
|
| Out of date checksum.  Have you tested this update?
| 
| ====================<phase 1: make checksum>====================
| => T-COFFEE_distribution_Version_3.27.tar.gz is not in /a/ports/biology/t_coffee/distinfo.
| => Either /a/ports/biology/t_coffee/distinfo is out of date, or
| => T-COFFEE_distribution_Version_3.27.tar.gz is spelled incorrectly.
| *** Error code 1
| 
| Stop in /a/ports/biology/t_coffee.
| 
| http://www.freebsd.org/cgi/query-pr.cgi?pr=93050
|
+----]

Of course, tested 3.18, 3.27 (submitted PR) and 3.67 (devel
version provided by author). 

But, I tested the USE_GCC=3.3 change also on the old version
(3.18) to see if the breakage was caused by a change in the
source code or if it was indeed caused by the newer gcc.

Then I updated PORTVERSION and submitted the PR. Of course,
I also forgot to update the distinfo :|

Attached is the correct patch. Thanks!

Fernan
Comment 4 Sam Lawrance freebsd_committer freebsd_triage 2006-02-10 09:46:23 UTC 
State Changed
From-To: feedback->closed

Committed, thanks! I conditionalised USE_GCC=3.3 specifically for 
platforms with gcc 3.4.