Bug 94749

Summary: [maintainer] databases/phpmyadmin -- correct an error in the previous update
Product: Ports & Packages Reporter: Matthew Seaman <m.seaman>
Component: Individual Port(s)Assignee: Marcus Alves Grando <mnag>
Status: Closed FIXED    
Severity: Affects Only Me CC: mnag
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
phpmyadmin.diff none

Description Matthew Seaman 2006-03-20 19:40:15 UTC 
Thanks to Matt Smith for bringing this to my attention.  OPTIONS
processing in the phpmyadmin Makefile happens rather early and so
requires that PORT_DBDIR be set in the Makefile directly.

Deleting the relevant line in the last update seems to have been an
error.
Comment 1 Yen-Ming Lee freebsd_committer freebsd_triage 2006-03-21 01:23:40 UTC 
Maybe you should take a look on Porter's Handbook first, and include
bsd.port.pre.mk and bsd.port.post.mk instead of define and include
OPTIONSFILE by yourself.

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html

-- 
Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan
Comment 2 Matthew Seaman 2006-03-21 07:02:10 UTC 
Yen-Ming Lee wrote:
> Maybe you should take a look on Porter's Handbook first, and include
> bsd.port.pre.mk and bsd.port.post.mk instead of define and include
> OPTIONSFILE by yourself.
> 
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html
> 


Unlike the general usage of OPTIONS, the options processing in this port
only affects the RUN_DEPENDS for the port.  This is the most effective
way to do that.

	Cheers,

	Matthew

-- 
Dr Matthew J Seaman MA, D.Phil.                       7 Priory Courtyard
                                                      Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey         Ramsgate
                                                      Kent, CT11 9PW
Comment 3 Marcus Alves Grando freebsd_committer freebsd_triage 2006-03-21 14:27:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mnag

I'll take it.
Comment 4 Marcus Alves Grando freebsd_committer freebsd_triage 2006-03-21 14:33:45 UTC 
State Changed
From-To: open->closed

Committed. Thanks. Why is not possible to use bsd.port.pre.mk and 
bsd.port.post.mk?