Bug 94818

Summary: /etc/rc.subr:1.43 breaks /usr/local/etc/rc.d/samba.sh restart
Product: Ports & Packages Reporter: Tai-hwa Liang <avatar>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Tai-hwa Liang 2006-03-22 02:20:06 UTC 
	
  Since /etc/rc.subr:1.43, /usr/local/etc/rc.d/samba.sh no longer can
restart all daemons properly.

Fix: Following workaround has been tested on RELENG_6 and HEAD.
Please check and commit it, thanks.
How-To-Repeat: 	
  Vanilla samba.sh from ports with latest /etc/rc.subr:

	# /usr/local/etc/rc.d/samba.sh restart
	Stopping /usr/local/sbin/nmbd.
	Starting SAMBA: removing stale tdbs :
	/var/db/samba/messages.tdb
	Starting nmbd.

  With patched samba.sh:

	# /usr/local/etc/rc.d/samba.sh restart
	Stopping /usr/local/sbin/nmbd.
	Starting SAMBA: removing stale tdbs :
	/var/db/samba/connections.tdb
	/var/db/samba/locking.tdb
	/var/db/samba/messages.tdb
	/var/db/samba/sessionid.tdb
	/var/db/samba/brlock.tdb
	Starting nmbd.
	Stopping /usr/local/sbin/smbd.
	Starting smbd.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-03-22 02:24:55 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Timur I. Bakeyev 2006-04-05 02:23:31 UTC 
Hi Tai-hwa!

Thanks a lot for the supplied fix!

It looks a bit hackish, as we are using internal variables, but at least 
'restart' works now. Added to the port update:

http://www.freebsd.org/cgi/query-pr.cgi?pr=95325

With best regards,
Timur.
Comment 3 Marcus Alves Grando freebsd_committer freebsd_triage 2006-04-05 03:01:10 UTC 
State Changed
From-To: feedback->closed

This fix are included in 95325. Thanks.