Bug 95624
| Summary: | [MAINTAINER] net/6tunnel - DISTVERSION is set incorrectly | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Shaun Amott <shaun> | ||||
| Component: | Individual Port(s) | Assignee: | Volker Stolz <vs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Shaun Amott
2006-04-11 15:40:17 UTC
State Changed From-To: open->feedback Can you please elaborate what the exact problem is? I do not see any need to change a thing. If you're going to use DISTVERSION, you usually DO NOT set PORTVERSION but rather let the framework do this automatically. Responsible Changed From-To: freebsd-ports-bugs->vs I'll track this. On Mon, Apr 17, 2006 at 01:53:31PM +0000, Volker Stolz wrote: > > Can you please elaborate what the exact problem is? > I do not see any need to change a thing. According to the Porter's Handbook: "DISTNAME is the name of the port as called by the authors of the software." Setting DISTNAME causes DISTVERSION to be set to the version in ports format (0.11.r2), rather than the author's format (0.11rc2), but setting DISTVERSION (which is the variable we really want to change) ensures both values are correct. There is in fact a reason for the change: the automated tool I am working on needs to be able to determine the original vendor-formatted version string from ports, and currently 6tunnel's DISTVERSION variable is incorrect. > If you're going to use DISTVERSION, you usually DO NOT set PORTVERSION > but rather let the framework do this automatically. > Hmm. I'm not sure how this would work... how can the ports system determine PORTVERSION from DISTVERSION? -- Shaun Amott [ PGP: 0x6B387A9A ] Scientia Est Potentia. On Mon, Apr 17, 2006 at 05:59:40PM +0100, Shaun Amott wrote: > There is in fact a reason for the change: the automated tool I am > working on needs to be able to determine the original vendor-formatted > version string from ports, and currently 6tunnel's DISTVERSION variable > is incorrect. I think your tool is working under the wrong assumptions. > > If you're going to use DISTVERSION, you usually DO NOT set PORTVERSION > > but rather let the framework do this automatically. > > Hmm. I'm not sure how this would work... how can the ports system > determine PORTVERSION from DISTVERSION? You can find the code for this in bsd.port.mk. Try removing PORTVERSION and DISTNAME from the Makefile and set DISTVERSION=0.11rc2. Observe the effect: 6tunnel@menelaos [19:08:14]> make -V PORTVERSION 0.11.r2 6tunnel@menelaos [19:08:34]> make -V DISTNAME 6tunnel-0.11rc2 Please drop me a line if you would like this modification to be carried out. the pre-configure target is redundant these days, too. Volker -- http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME "All the excitement lies in pattern matching." (SPJ et al.) On Mon, Apr 17, 2006 at 07:18:46PM +0200, Volker Stolz wrote:
>
> You can find the code for this in bsd.port.mk.
> Try removing PORTVERSION and DISTNAME from the Makefile and
> set DISTVERSION=0.11rc2. Observe the effect:
>
> 6tunnel@menelaos [19:08:14]> make -V PORTVERSION
> 0.11.r2
> 6tunnel@menelaos [19:08:34]> make -V DISTNAME
> 6tunnel-0.11rc2
>
> Please drop me a line if you would like this modification to be carried out.
> the pre-configure target is redundant these days, too.
>
Okay.. this is fine.
Please make the change, and you can remove pre-configure too.
--
Shaun Amott [ PGP: 0x6B387A9A ]
Scientia Est Potentia.
State Changed From-To: feedback->closed Port updated, thanks! |
