Bug 96209

Summary: Gnash + Firefox crash
Product: Ports & Packages Reporter: User & <sanluca78>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description User & 2006-04-23 18:00:30 UTC 
Gnash + Firefox Crash

How-To-Repeat: 12:01:15: SetWindow: X origin = 23, Y Origin = 0, Width = 728, Height = 90, WindowID = 0x2a00a4f, this = 0x197f400
12:01:15: TRACE: void nsPluginInstance::lockGL(): for instance 0x197f400
12:01:15: TRACE: void nsPluginInstance::lockX(): for instance 0x197f400
12:01:15: SetWindow: Got new glxContext 0x1989400
12:01:15: TRACE: void nsPluginInstance::setGL(): gxDisplay = 0x197e000, _window = 0x2a00a4f, _glxContext = 0x1989400 for instance 0x197f400
The program 'Gecko' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadMatch (invalid parameter attributes)'.
  (Details: serial 22 error_code 8 request_code 142 minor_code 5)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
nsStringStats
 => mAllocCount:          42368
 => mReallocCount:         4049
 => mFreeCount:           36409  --  LEAKED 5959 !!!
 => mShareCount:          19853
 => mAdoptCount:           2329
 => mAdoptFreeCount:       2276  --  LEAKED 53 !!!
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-04-24 01:29:16 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Dmitry Marakasov 2006-04-27 03:13:51 UTC 
* Edwin Groothuis (edwin@FreeBSD.org) wrote:
> Please note that PR ports/96209 has just been submitted.

I've made a patch to disable plugin (for the case it crashes firefox).

As gnash still isn't considered stable, such stings are likely to
happen... I'll forward tihs and future bug reports to author.

--- gnash.patch begins here ---
diff -ruN gnash.old/Makefile gnash/Makefile
--- gnash.old/Makefile	Sat Apr 22 17:52:03 2006
+++ gnash/Makefile	Thu Apr 27 05:36:25 2006
@@ -7,7 +7,7 @@
 
 PORTNAME=	gnash
 PORTVERSION=	0.7
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics
 MASTER_SITES=	${MASTER_SITE_LOCAL}
 MASTER_SITE_SUBDIR=	ale
@@ -18,13 +18,12 @@
 
 LIB_DEPENDS=	png.5:${PORTSDIR}/graphics/png \
 		jpeg.9:${PORTSDIR}/graphics/jpeg \
-		ogg.5:${PORTSDIR}/audio/libogg \
-		gtkglext-x11-1.0.2:${PORTSDIR}/x11-toolkits/gtkglext
+		ogg.5:${PORTSDIR}/audio/libogg
 
 USE_BZIP2=	yes
 USE_GL=		yes
 USE_GMAKE=	yes
-USE_GNOME=	gnomehier gtk20 glib20 atk pango pkgconfig libxml2
+USE_GNOME=	gnomehier glib20 pkgconfig libxml2
 USE_SDL=	sdl mixer
 USE_X_PREFIX=	yes
 USE_GCC=	3.4+
@@ -41,9 +40,28 @@
 
 WRKSRC=		${WRKDIR}/${PORTNAME}-20060422
 
+OPTIONS=	PLUGIN	"Enable firefox plugin" off
+
+.include <bsd.port.pre.mk>
+
+.if !defined(WITH_PLUGIN)
+CONFIGURE_ARGS+=	--disable-plugin
+PLIST_SUB+=	PLUGIN="@comment "
+.else
+USE_GNOME+=	atk pango gtk20
+LIB_DEPENDS+=	gtkglext-x11-1.0.2:${PORTSDIR}/x11-toolkits/gtkglext
+PLIST_SUB+=	PLUGIN=""
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' ${WRKSRC}/macros/*.m4
 	@${REINPLACE_CMD} -e 's|/usr/X11R6|${X11BASE}|g' ${WRKSRC}/macros/*.m4
 	@${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|g' ${WRKSRC}/macros/*.m4
+	@${REINPLACE_CMD} -e 's|^AM_LDFLAGS = \\|AM_LDFLAGS = $$(PTHREAD_LIBS) \\|' ${WRKSRC}/utilities/Makefile.am
+
+.if !defined(WITH_PLUGIN)
+post-configure:
+	@${REINPLACE_CMD} -e '/STD_DIRS/ s|plugin||' ${WRKSRC}/Makefile
+.endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
diff -ruN gnash.old/pkg-plist gnash/pkg-plist
--- gnash.old/pkg-plist	Sat Apr 22 16:33:58 2006
+++ gnash/pkg-plist	Thu Apr 27 05:32:50 2006
@@ -1,7 +1,7 @@
 bin/gnash
 bin/gparser
 bin/gprocessor
-lib/browser_plugins/libgnashplugin.so
+%%PLUGIN%%lib/browser_plugins/libgnashplugin.so
 lib/gnash/libgnashasobjs.a
 lib/gnash/libgnashasobjs.la
 lib/gnash/libgnashasobjs.so
@@ -23,4 +23,4 @@
 lib/gnash/libgnashserver.so
 lib/gnash/libgnashserver.so.0
 @dirrm lib/gnash
-@dirrmtry lib/browser_plugins
+%%PLUGIN%%@dirrmtry lib/browser_plugins
--- gnash.patch ends here ---

-- 
Best regards,
 Dmitry                          mailto:amdmi3@mail.ru
Comment 3 Alex Dupre freebsd_committer freebsd_triage 2006-04-27 07:41:31 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!