Bug 97698
| Summary: | [PATCH] dns/crossip: Update to bsd.java.mk 2.0 and other improvements | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Herve Quiroz <hq> | ||||
| Component: | Individual Port(s) | Assignee: | Herve Quiroz <hq> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dan | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-ports-bugs->hq Submitter is a commiter State Changed From-To: open->feedback Awaiting maintainers feedback This patch looks good. Thanks! Cheers, Dan At 11:52 AM 5/23/2006, you wrote: >Maintainer of dns/crossip, > >Please note that PR ports/97698 has just been submitted. > >If it contains a patch for an upgrade, an enhancement or a bug fix >you agree on, reply to this email stating that you approve the patch >and a committer will take care of it. > >The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/97698 > >-- >Edwin Groothuis >edwin@FreeBSD.org --------------------------- Dan Smith +1 608-213-2867 Algenta Technologies, LLC http://www.algenta.com State Changed From-To: feedback->patched Patch approved and commited. State Changed
From-To: patched->feedback
What shall we do regarding these two issues?
> NOTE 1: I don't know well enough this application to understand if the JAR file
> is indeed needed in ${JAVAJARDIR}. The new launcher uses the JAR file in
> ${DATADIR} anyway and seems to run fine. I would be glad if we could remove all
> JAR files from ${JAVAJARDIR} that are not needed because many ports include all
> files from this directory in their CLASSPATH.
>
> NOTE 2: I don't think having *.class and *.java files in ${DATADIR} is useful.
> But that's up to the maintainer to decide.
I can provide a new patch for both of these...
Hi Herve, At 05:49 PM 5/23/2006, you wrote: > > NOTE 1: I don't know well enough this application to understand if the > JAR file > > is indeed needed in ${JAVAJARDIR}. The Jar file simply contains the invokable classes. I don't know of any applications that link to this, so removing from ${JAVAJARDIR} is fine. > > NOTE 2: I don't think having *.class and *.java files in ${DATADIR} is > useful. > > But that's up to the maintainer to decide. Sounds good, since the wrapper executes the jar file directly these mostly just take up space. Thanks! Dan --------------------------- Dan Smith +1 608-213-2867 Algenta Technologies, LLC http://www.algenta.com State Changed From-To: feedback->closed Suggested modifications approved. Patch commited. |
- Update to bsd.java.mk 2.0 - Use DISTVERSION to avoid complex substitutions in DISTNAME - Use DATADIR=${JAVASHAREDIR}/${PORTNAME} - Use SUB_FILES to configure launcher shell script - Set JAVA_VERSION in launcher shell script - Use 'exec' to launch JVM (as encouraged in the Porter's Handbook) - Remove port name from COMMENT - Do not mkdir ${JAVAJARDIR} (it is part of mtree now) - Use %%DATADIR%% and %%JAVAJARDIR%% in pkg-plist - Add $FreeBSD$ tags NOTE 1: I don't know well enough this application to understand if the JAR file is indeed needed in ${JAVAJARDIR}. The new launcher uses the JAR file in ${DATADIR} anyway and seems to run fine. I would be glad if we could remove all JAR files from ${JAVAJARDIR} that are not needed because many ports include all files from this directory in their CLASSPATH. NOTE 2: I don't think having *.class and *.java files in ${DATADIR} is useful. But that's up to the maintainer to decide. Added file(s): - files/crossip.sh.in Removed file(s): - files/wrapper.sh Port maintainer (dan@algenta.com) is cc'd. Generated with FreeBSD Port Tools 0.77