Bug 98955

Summary: [PATCH] devel/p5-Test-WWW-Mechanize: update to 1.08
Product: Ports & Packages Reporter: Aaron Dalton <aaron>
Component: Individual Port(s)Assignee: Aaron Dalton <aaron>
Status: Closed FIXED    
Severity: Affects Only Me CC: fbsdports
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
p5-Test-WWW-Mechanize-1.08.patch
none
diff.txt none

Description Aaron Dalton freebsd_committer freebsd_triage 2006-06-14 20:30:15 UTC 
- Update to 1.08

Port maintainer (fbsdports@commit.it) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-06-14 20:32:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->aaron

Submitter has GNATS access
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2006-06-14 20:32:29 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Angelo Turetta 2006-06-15 10:06:40 UTC 
Aaron Dalton wrote:

>  BUILD_DEPENDS=	${SITE_PERL}/WWW/Mechanize.pm:${PORTSDIR}/www/p5-WWW-Mechanize \
> +		${SITE_PERL}/URI/file.pm:${PORTSDIR}/net/p5-URI \
> +		${SITE_PERL}/Carp/Assert/More.pm:${PORTSDIR}/devel/p5-Carp-Assert-More \
> +		${SITE_PERL}/HTTP/Server/Simple.pm:${PORTSDIR}/www/p5-HTTP-Server-Simple \
>  		${SITE_PERL}/Test/LongString.pm:${PORTSDIR}/devel/p5-Test-LongString
>  RUN_DEPENDS=	${BUILD_DEPENDS}

For what I understand, HTTP::Server::Simple and URI::File are not direct 
dependencies of this module. They are brought in automatically by 
WWW::Mechanize. If that's true, please don't add them here.

> -.if ${PERL_LEVEL} < 500800
> -BUILD_DEPENDS+=	${SITE_PERL}/Test/Builder.pm:${PORTSDIR}/devel/p5-Test-Simple
>  .if ${PERL_LEVEL} < 500601
>  IGNORE=		requires perl 5.6.x or later. Install lang/perl5.8 then try again
>  .endif
> -.endif

Are you sure p5-Test-Simple is included in perl5.6.1 ?

Otherwise, fine for me.

Angelo.
Comment 4 Aaron Dalton freebsd_committer freebsd_triage 2006-06-15 22:57:28 UTC 
Angelo Turetta wrote:
> Aaron Dalton wrote:
> 
>>  BUILD_DEPENDS=    
>> ${SITE_PERL}/WWW/Mechanize.pm:${PORTSDIR}/www/p5-WWW-Mechanize \
>> +        ${SITE_PERL}/URI/file.pm:${PORTSDIR}/net/p5-URI \
>> +        
>> ${SITE_PERL}/Carp/Assert/More.pm:${PORTSDIR}/devel/p5-Carp-Assert-More \
>> +        
>> ${SITE_PERL}/HTTP/Server/Simple.pm:${PORTSDIR}/www/p5-HTTP-Server-Simple 
>> \
>>          
>> ${SITE_PERL}/Test/LongString.pm:${PORTSDIR}/devel/p5-Test-LongString
>>  RUN_DEPENDS=    ${BUILD_DEPENDS}
> 
> 
> For what I understand, HTTP::Server::Simple and URI::File are not direct 
> dependencies of this module. They are brought in automatically by 
> WWW::Mechanize. If that's true, please don't add them here.
> 

The updated Makefile.PL states:
     PREREQ_PM => {
         'Test::More'        => 0,
         'Test::LongString'  => '0.07',
         'URI::file'         => 0,
         'WWW::Mechanize'    => '1.00',
         'Carp::Assert::More' => 0,
         'HTTP::Server::Simple' => '0.07',
     },

>> -.if ${PERL_LEVEL} < 500800
>> -BUILD_DEPENDS+=    
>> ${SITE_PERL}/Test/Builder.pm:${PORTSDIR}/devel/p5-Test-Simple
>>  .if ${PERL_LEVEL} < 500601
>>  IGNORE=        requires perl 5.6.x or later. Install lang/perl5.8 
>> then try again
>>  .endif
>> -.endif
> 
> 
> Are you sure p5-Test-Simple is included in perl5.6.1 ?
> 

True.  My test box has 5.6.2.  I'll alter the if statement and submit an 
updated patch.

-- 
Aaron Dalton
aaron@FreeBSD.org
FreeBSD Ports Committer
Comment 5 Aaron Dalton freebsd_committer freebsd_triage 2006-06-15 23:03:30 UTC 
Here's the updated patch:

-- 
Aaron Dalton
aaron@FreeBSD.org
FreeBSD Ports Committer
Comment 6 Angelo Turetta 2006-06-16 10:26:20 UTC 
Please commit.

Thanks,
Angelo
Comment 7 Aaron Dalton freebsd_committer freebsd_triage 2006-06-16 11:09:31 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!