Bug 100488 - devel/libusb buil fails WITH_SGML
Summary: devel/libusb buil fails WITH_SGML
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-18 15:40 UTC by Jacula Modyun
Modified: 2006-07-29 22:06 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jacula Modyun 2006-07-18 15:40:14 UTC
The libusb build depends by the /usr/local/share/sgml/docbook/4.2/catalog file. But the textproc/docbook port install the textproc/docbook-xml port, that is a only a part of the textproc/docbook-420 port. 
The docbook 4.2 includes the XML DocBook DTD as part of the SGML DTD distribution.
Then if you build devel/libusb WITH_SGML=1 and your sistem hasn't already installed the textproc/docbook-420 ports, the build failes.

Fix: 

My litle hack is a Makefile.local with the line:

BUILD_DEPENDS+= ${LOCALBASE}/share/sgml/docbook/4.2/catalog:${PORTSDIR}/textproc/docbook-420
How-To-Repeat: cd /usr/ports/devel/libusb
make config
SGML=on
make showconfig 
===> The following configuration options are available for libusb-0.1.12:
     SGML=on "Install developer guide from SGML"
===> Use 'make config' to modify these settings
make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-07-18 15:40:43 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Rene Ladan 2006-07-18 19:08:36 UTC
Edwin Groothuis wrote:
> Maintainer of devel/libusb,
> 
> Please note that PR ports/100488 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/100488
> 
Patch approved, I think it's cleaner to add it to Makefile (in the
WITH_SGML part) to avoid having a Makefile.local

Regards,
Rene
-- 
GPG fingerprint = E738 5471 D185 7013 0EE0  4FC8 3C1D 6F83 12E1 84F6
(subkeys.pgp.net)

"It won't fit on the line."
		-- me, 2001
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2006-07-18 23:16:03 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 4 Jacula Modyun 2006-07-19 10:09:08 UTC
Yes, I know that it's cleaner to add it to Makefile. But I used a
Makefile.local, because I think it can be only a temporary hack.
The problem, for me, is the textproc/docbook port. This port run-depends
by the textproc/docbook-xml, and when you install both textproc/docbook-xml
and textproc/docbook-420, you will have duplicates of most of the files.
Then I think It's better, for me, that the textproc/docbook use the
WITH_SGML knob and this knob is WITH_SGML=1 by default. So you can
chose if your system has these duplicated files.

Best Regards by Jacula Modyun
Comment 5 Rene Ladan 2006-07-19 12:31:34 UTC
The patch should be in the main Makefile, since the WITH_SGML knob is
not propagated to Makefile.local, and if the dependency in
Makefile.local is not contained within the WITH_SGML knob, it is always
installed which is both unnecessary and unclean.

Regards,
Rene
-- 
GPG fingerprint = E738 5471 D185 7013 0EE0  4FC8 3C1D 6F83 12E1 84F6
(subkeys.pgp.net)

"It won't fit on the line."
		-- me, 2001
Comment 6 Tilman Keskinoz freebsd_committer freebsd_triage 2006-07-29 22:06:05 UTC
State Changed
From-To: open->closed

A patch was committed, thanks for reporting