It's a good practice to check non-default options in makefiles. I.e. check for WITH_OPT if OPT is off by default, and for WITHOUT_OPT if OPT is on by default. This will allow correct behavior when overriding options from make.conf. See games/cube and other ports.
Over to maintainer
Committed thanks :)
acm 2006-11-06 18:19:46 UTC
FreeBSD ports repository
- Use the correct way to check the default options on Makefile
Submitted by: Dmitry Marakasov <amdmi3__at__mail.ru>
Revision Changes Path
1.9 +3 -3 ports/games/sauerbraten/Makefile
email@example.com mailing list
To unsubscribe, send any mail to "firstname.lastname@example.org"
a lot of ports have bogus OPTIONS checks, but this should only be a
problem if BATCH or PACKAGE_BUILDING is defined.
Could you please review the change at
to see if it would fix the problem with sauerbraten? IMHO, this is a
more complete fix.
In total, I count 252 affected ports, maintained by 148 maintainers. I
can publish the list upon request, but PR 105147 is the real fix, IMHO.