Bug 107256 - [MAINT] multimedia/gstreamer: Add gstreamer-plugins-good dep
[MAINT] multimedia/gstreamer: Add gstreamer-plugins-good dep
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: mezz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-12-27 22:10 UTC by johnson.peter
Modified: 2006-12-28 18:50 UTC (History)
0 users

See Also:


Attachments
quodlibet-gstreamer.patch (610 bytes, patch)
2006-12-27 22:10 UTC, johnson.peter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description johnson.peter 2006-12-27 22:10:05 UTC
Port does not currently depend on gstreamer-plugins-good, but this is required
for media with ID3 tags to be playable (as this needs id3demux, part of
gstreamer-plugins-good, to be installed).

Fix: Patch attached.
How-To-Repeat: Clean install of port will not install gstreamer-plugins-good, and thus will
not play media with ID3 tags.
Comment 1 Edwin Groothuis freebsd_committer 2006-12-27 22:10:16 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer)
Comment 2 Edwin Groothuis freebsd_committer 2006-12-27 22:10:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-multimedia

Over to maintainer
Comment 3 mezz freebsd_committer 2006-12-27 23:09:49 UTC
Class Changed
From-To: change-request->maintainer-update

Actually, the 'multimedia/gstreamer' is a typo, which it is supposed to be 
'multimedia/quodlibet' by looked at his patch. Therefore, it is correct that 
he is a maintainer. 


Comment 4 mezz freebsd_committer 2006-12-27 23:09:49 UTC
Responsible Changed
From-To: freebsd-multimedia->freebsd-ports-bugs

Actually, the 'multimedia/gstreamer' is a typo, which it is supposed to be 
'multimedia/quodlibet' by looked at his patch. Therefore, it is correct that 
he is a maintainer.
Comment 5 mezz freebsd_committer 2006-12-27 23:18:02 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mezz

I'll take this.
Comment 6 mezz freebsd_committer 2006-12-27 23:29:15 UTC
State Changed
From-To: open->feedback

I have tweaked it a bit, so what do you think of this before I commit it? 

http://people.freebsd.org/~mezz/diff/quodlibet.diff 

-Remove USE_GSTREAMER=yes, taken care by USE_GSTREAMER=foobar 
-Move from (BUILD|RUN)_DEPENDS=[...]py-gstreamer to USE_GSTREAMER=python 
-Move from (BUILD|RUN)_DEPENDS=[...]py-gnome-extras to USE_GNOME+=pygnomeextras
Comment 7 dfilter freebsd_committer 2006-12-28 18:46:56 UTC
mezz        2006-12-28 18:46:50 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/quodlibet Makefile 
  Log:
  - Add the gstreamer-plugins-good dependency to make ID3 tags to be playable,
    bump the PORTREVISION.
  - Remove USE_GSTREAMER=yes, taken care by USE_GSTREAMER=foobar
  - Move from (BUILD|RUN)_DEPENDS=[...]py-gstreamer to USE_GSTREAMER=python
  - Move from (BUILD|RUN)_DEPENDS=[...]py-gnome-extras to USE_GNOME+=pygnomeextras
  
  PR:             ports/107256
  Submitted by:   Peter Johnson <johnson.peter@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.17      +5 -9      ports/multimedia/quodlibet/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 mezz freebsd_committer 2006-12-28 18:46:57 UTC
State Changed
From-To: feedback->closed

Committed, thanks!